Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2811253005: Reland of land "Add first part of the network_tester functionality" (Closed)

Created:
3 years, 8 months ago by minyue-webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of land "Add first part of the network_tester functionality" (patchset #1 id:1 of https://codereview.webrtc.org/2813193002/ ) Reason for revert: The blocker in upstreaming has been removed. Original issue's description: > Revert of Reland "Add first part of the network_tester functionality" (patchset #3 id:40001 of https://codereview.chromium.org/2808203003/ ) > > Reason for revert: > Break downstream bots. > > Original issue's description: > > Reland "Add first part of the network_tester functionality" > > > > BUG=webrtc:7426 > > > > Review-Url: https://codereview.webrtc.org/2808203003 > > Cr-Commit-Position: refs/heads/master@{#17666} > > Committed: https://chromium.googlesource.com/external/webrtc/+/1c223b2f7557ff449add7a114d72ea97614731b5 > > TBR=stefan@webrtc.org,minyue@webrtc.org,nisse@webrtc.org,terelius@webrtc.org,michaelt@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7426 > > Review-Url: https://codereview.webrtc.org/2813193002 > Cr-Commit-Position: refs/heads/master@{#17672} > Committed: https://chromium.googlesource.com/external/webrtc/+/e5fd38989de6900cd32e7c88932201ec3b3467d8 TBR=stefan@webrtc.org,nisse@webrtc.org,terelius@webrtc.org,michaelt@webrtc.org,philipel@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7426 Review-Url: https://codereview.webrtc.org/2811253005 Cr-Commit-Position: refs/heads/master@{#17688} Committed: https://chromium.googlesource.com/external/webrtc/+/cb067fa117afd9ef4e1e18daf97a7bdd35888a75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+680 lines, -0 lines) Patch
A resources/network_tester/client_config.dat.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A resources/network_tester/server_config.dat.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/tools/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/tools/network_tester/BUILD.gn View 1 chunk +93 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/config_reader.h View 1 chunk +53 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/config_reader.cc View 1 chunk +50 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/create_network_tester_config.py View 1 chunk +30 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/network_tester_config.proto View 1 chunk +13 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/network_tester_packet.proto View 1 chunk +18 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/network_tester_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/packet_sender.h View 1 chunk +64 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/packet_sender.cc View 1 chunk +129 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/test_controller.h View 1 chunk +75 lines, -0 lines 0 comments Download
A webrtc/tools/network_tester/test_controller.cc View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
minyue-webrtc
Created Reland of land "Add first part of the network_tester functionality"
3 years, 8 months ago (2017-04-13 08:23:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2811253005/1
3 years, 8 months ago (2017-04-13 08:23:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/cb067fa117afd9ef4e1e18daf97a7bdd35888a75
3 years, 8 months ago (2017-04-13 08:24:08 UTC) #6
minyue-webrtc
3 years, 8 months ago (2017-04-13 10:03:35 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2810423002/ by minyue@webrtc.org.

The reason for reverting is: Still break upstream..

Powered by Google App Engine
This is Rietveld 408576698