Reland "Add first part of the network_tester functionality"

Reland "Add first part of the network_tester functionality"

BUG=webrtc:7426
Review-Url: https://codereview.webrtc.org/2808203003
Cr-Commit-Position: refs/heads/master@{#17666}
Committed: https://chromium.googlesource.com/external/webrtc/+/1c223b2f7557ff449add7a114d72ea97614731b5

[michaelt, 2017-04-11 08:36:59]

Description was changed from

==========
Reland "Add first part of the network_tester functionality"

BUG=webrtc:7426
==========

to

==========
Reland "Add first part of the network_tester functionality"

BUG=webrtc:7426
==========

[michaelt, 2017-04-11 08:36:59]

michaelt@webrtc.org changed reviewers:
+ minyue@webrtc.org, nisse@webrtc.org, stefan@webrtc.org, terelius@webrtc.org

[michaelt, 2017-04-11 08:49:48]

Hi, 
Here the reland of the cl "https://codereview.webrtc.org/2779233002/".

The dtor of worker_queue_ was called at the end of dtor of PacketSender. Which
was a bad idea :).

[stefan-webrtc, 2017-04-11 08:59:00]

lgtm

https://codereview.webrtc.org/2808203003/diff/20001/webrtc/tools/network_test...
File webrtc/tools/network_tester/packet_sender.h (right):

https://codereview.webrtc.org/2808203003/diff/20001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.h:51: size_t packet_size_
GUARDED_BY(worker_queue_checker_);
Is ACCESS_ON(worker_queue_) an option?

[minyue-webrtc, 2017-04-11 09:49:15]

lgtm

[michaelt, 2017-04-11 11:53:30]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 11:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-11 12:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 12:16:06]

Dry run: This issue passed the CQ dry run.

[minyue-webrtc, 2017-04-12 08:47:52]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2017-04-12 08:47:53]

The patchset sent to the CQ was uploaded after l-g-t-m from minyue@webrtc.org,
stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2808203003/#ps40001 (title:
"use ACCESS_ON instead of GUARDED_BY")

[commit-bot: I haz the power, 2017-04-12 08:48:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-12 08:50:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491986872816950,
"parent_rev": "07e20db42dbf866e76ae52f8f7dfd6274e1f1045", "commit_rev":
"1c223b2f7557ff449add7a114d72ea97614731b5"}

[commit-bot: I haz the power, 2017-04-12 08:50:39]

Description was changed from

==========
Reland "Add first part of the network_tester functionality"

BUG=webrtc:7426
==========

to

==========
Reland "Add first part of the network_tester functionality"

BUG=webrtc:7426

Review-Url: https://codereview.webrtc.org/2808203003
Cr-Commit-Position: refs/heads/master@{#17666}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1c223b2f7557ff449add7a114...
==========

[commit-bot: I haz the power, 2017-04-12 08:50:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/1c223b2f7557ff449add7a114...

[philipel, 2017-04-12 12:07:42]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2813193002/ by philipel@webrtc.org.

The reason for reverting is: Break downstream bots..

[michaelt, 2017-04-12 15:18:16]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2815573004/ by michaelt@webrtc.org.

The reason for reverting is: Hit infra. bug. which need to be fixed first..