Move IsIntlike to type_traits.h

Move IsIntlike to type_traits.h

I'll start using it outside safe_compare.h soon.

BUG=webrtc:7459
Review-Url: https://codereview.webrtc.org/2809513002
Cr-Commit-Position: refs/heads/master@{#17620}
Committed: https://chromium.googlesource.com/external/webrtc/+/b0f7e39fd43a0ce4643ac90c1449d5c0d0f8d55b

[kwiberg-webrtc, 2017-04-08 12:08:04]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 12:08:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-04-08 12:08:43]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-04-08 12:09:03]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/19342)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/19136)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/24644)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/23475)

[kwiberg-webrtc, 2017-04-08 12:09:32]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[kwiberg-webrtc, 2017-04-08 12:14:44]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 12:14:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-04-08 12:15:12]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-08 14:15:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 14:15:17]

Dry run: Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  mac_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build hasn't started
yet, builder probably lacks capacity)
  win_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build hasn't started
yet, builder probably lacks capacity)

[ossu, 2017-04-10 11:26:03]

lgtm

What's the reason for excluding strongly typed enums? I'd think they were
integer-like enough to be included, even if they don't convert implicitly to
integers.

[kwiberg-webrtc, 2017-04-10 11:37:01]

On 2017/04/10 11:26:03, ossu wrote:
> lgtm
> 
> What's the reason for excluding strongly typed enums? I'd think they were
> integer-like enough to be included, even if they don't convert implicitly to
> integers.

They don't convert implicitly to integers, so people don't expect them to behave
like integers. IsIntlike is used by functions that want to accept integer types,
even if they happen to be enums that just convert implicitly to integers. If it
also accepted enums that didn't convert implicitly to integers, people would be
surprised and dismayed.

[kwiberg-webrtc, 2017-04-10 11:46:46]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-04-10 11:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 13:56:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491824806918720,
"parent_rev": "37e99fd3fa4d49b87a58a58e9605af01cdb45d16", "commit_rev":
"b0f7e39fd43a0ce4643ac90c1449d5c0d0f8d55b"}

[commit-bot: I haz the power, 2017-04-10 13:57:02]

Description was changed from

==========
Move IsIntlike to type_traits.h

I'll start using it outside safe_compare.h soon.

BUG=webrtc:7459
==========

to

==========
Move IsIntlike to type_traits.h

I'll start using it outside safe_compare.h soon.

BUG=webrtc:7459

Review-Url: https://codereview.webrtc.org/2809513002
Cr-Commit-Position: refs/heads/master@{#17620}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b0f7e39fd43a0ce4643ac90c1...
==========

[commit-bot: I haz the power, 2017-04-10 13:57:03]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/b0f7e39fd43a0ce4643ac90c1...