Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2808603002: Make safe_cmp::* constexpr (Closed)

Created:
3 years, 8 months ago by kwiberg-webrtc
Modified:
3 years, 8 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make safe_cmp::* constexpr Because it's easy and generally useful, and because a later CL in this series needs it. BUG=webrtc:7459 Review-Url: https://codereview.webrtc.org/2808603002 Cr-Commit-Position: refs/heads/master@{#17633} Committed: https://chromium.googlesource.com/external/webrtc/+/0d4e068d0a79d3ecd938f2de7aa41fb51a1ff084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -282 lines) Patch
M webrtc/base/safe_compare.h View 8 chunks +22 lines, -20 lines 0 comments Download
M webrtc/base/safe_compare_unittest.cc View 8 chunks +262 lines, -262 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (15 generated)
kwiberg-webrtc
3 years, 8 months ago (2017-04-08 12:16:08 UTC) #9
ossu
lgtm
3 years, 8 months ago (2017-04-10 11:37:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808603002/20001
3 years, 8 months ago (2017-04-10 19:53:59 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-04-10 21:54:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808603002/20001
3 years, 8 months ago (2017-04-11 05:41:04 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 05:44:12 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0d4e068d0a79d3ecd938f2de7...

Powered by Google App Engine
This is Rietveld 408576698