Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2808333006:
Don't make a top-level namespace called "internal" (Closed)
|
Created:
3 years, 8 months ago by kwiberg-webrtc Modified:
3 years, 8 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDon't make a top-level namespace called "internal"
That name isn't unique enough---someone else may be using it. Not a
big problem in practice in this file, but it's the principle of the
thing.
BUG=webrtc:7484
Review-Url: https://codereview.webrtc.org/2808333006
Cr-Commit-Position: refs/heads/master@{#17697}
Committed: https://chromium.googlesource.com/external/webrtc/+/2a4c63aa13e8391206f8a42cd2fee20db686f0e8
Patch Set 1 #
Total comments: 2
Patch Set 2 : make namespace anonymous, and drop the unnecessary webrtc:: prefixes #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kwiberg@webrtc.org changed reviewers: + magjed@webrtc.org
https://codereview.webrtc.org/2808333006/diff/1/webrtc/sdk/objc/Framework/Cla... File webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc (right): https://codereview.webrtc.org/2808333006/diff/1/webrtc/sdk/objc/Framework/Cla... webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc:28: namespace internal { Can you make this an anonymous namespace instead? Also, if you put it inside the webrtc namespace, can you take the opportunity to remove the unnecessary 'webrtc::'?
The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #2 (id:20001) has been deleted
https://codereview.webrtc.org/2808333006/diff/1/webrtc/sdk/objc/Framework/Cla... File webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc (right): https://codereview.webrtc.org/2808333006/diff/1/webrtc/sdk/objc/Framework/Cla... webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc:28: namespace internal { On 2017/04/13 09:35:44, magjed_webrtc wrote: > Can you make this an anonymous namespace instead? Also, if you put it inside the > webrtc namespace, can you take the opportunity to remove the unnecessary > 'webrtc::'? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by kwiberg@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492091305179870,
"parent_rev": "749cc8a49371fefc701bb049faf6bdb821203dcb", "commit_rev":
"2a4c63aa13e8391206f8a42cd2fee20db686f0e8"}
Message was sent while issue was closed.
Description was changed from ========== Don't make a top-level namespace called "internal" That name isn't unique enough---someone else may be using it. Not a big problem in practice in this file, but it's the principle of the thing. BUG=webrtc:7484 ========== to ========== Don't make a top-level namespace called "internal" That name isn't unique enough---someone else may be using it. Not a big problem in practice in this file, but it's the principle of the thing. BUG=webrtc:7484 Review-Url: https://codereview.webrtc.org/2808333006 Cr-Commit-Position: refs/heads/master@{#17697} Committed: https://chromium.googlesource.com/external/webrtc/+/2a4c63aa13e8391206f8a42cd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/2a4c63aa13e8391206f8a42cd... |
