Don't make a top-level namespace called "internal"

webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  *
  */
 
 #include "webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.h"
 
 #include <memory>
 
 #if defined(WEBRTC_IOS)
 #include "RTCUIApplication.h"
 #endif
 #include "libyuv/convert.h"
 #include "webrtc/api/video/video_frame.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/common_video/include/corevideo_frame_buffer.h"
 #include "webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.h"
 #include "webrtc/video_frame.h"
 
+namespace webrtc {
 namespace internal {

[magjed_webrtc, 2017/04/13 09:35:44]

Can you make this an anonymous namespace instead? Also, if you put it inside the
webrtc namespace, can you take the opportunity to remove the unnecessary
'webrtc::'?

[kwiberg-webrtc, 2017/04/13 11:49:03]

Done.

 
 static const int64_t kMsPerSec = 1000;
 
 // Convenience function for creating a dictionary.
 inline CFDictionaryRef CreateCFDictionary(CFTypeRef* keys,
                                           CFTypeRef* values,
                                           size_t size) {
   return CFDictionaryCreate(nullptr, keys, values, size,
                             &kCFTypeDictionaryKeyCallBacks,
                             &kCFTypeDictionaryValueCallBacks);
@@ skipping 27 matching lines @@
   rtc::scoped_refptr<webrtc::VideoFrameBuffer> buffer =
       new rtc::RefCountedObject<webrtc::CoreVideoFrameBuffer>(image_buffer);
   webrtc::VideoFrame decoded_frame(buffer, decode_params->timestamp,
                                    CMTimeGetSeconds(timestamp) * kMsPerSec,
                                    webrtc::kVideoRotation_0);
   decode_params->callback->Decoded(decoded_frame);
 }
 
 }  // namespace internal
 
-namespace webrtc {
-
 H264VideoToolboxDecoder::H264VideoToolboxDecoder()
     : callback_(nullptr),
       video_format_(nullptr),
       decompression_session_(nullptr) {}
 
 H264VideoToolboxDecoder::~H264VideoToolboxDecoder() {
   DestroyDecompressionSession();
   SetVideoFormat(nullptr);
 }
 
@@ skipping 182 matching lines @@
   if (video_format_) {
     CFRetain(video_format_);
   }
 }
 
 const char* H264VideoToolboxDecoder::ImplementationName() const {
   return "VideoToolbox";
 }
 
 }  // namespace webrtc