Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2807533004: Address denicija's comments for AppRTCMobile video codec setting. (Closed)

Created:
3 years, 8 months ago by sakal
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Address denicija's comments for AppRTCMobile video codec setting. Comments in review: https://codereview.webrtc.org/2735303004/ BUG=webrtc:7316 Review-Url: https://codereview.webrtc.org/2807533004 Cr-Commit-Position: refs/heads/master@{#17650} Committed: https://chromium.googlesource.com/external/webrtc/+/268862c5e418e5c05e8f10d6338dc89f14d282d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M webrtc/examples/objc/AppRTCMobile/ARDSettingsModel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsViewController.m View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
sakal
PTAL
3 years, 8 months ago (2017-04-07 11:17:09 UTC) #3
daniela-webrtc
lgtm
3 years, 8 months ago (2017-04-11 07:33:19 UTC) #4
daniela-webrtc
lgtm
3 years, 8 months ago (2017-04-11 07:33:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2807533004/1
3 years, 8 months ago (2017-04-11 07:34:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16031)
3 years, 8 months ago (2017-04-11 07:40:10 UTC) #9
sakal
Magnus, can you PTAL?
3 years, 8 months ago (2017-04-11 12:22:59 UTC) #11
magjed_webrtc
lgtm
3 years, 8 months ago (2017-04-11 12:26:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2807533004/1
3 years, 8 months ago (2017-04-11 12:26:26 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 12:36:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/268862c5e418e5c05e8f10d63...

Powered by Google App Engine
This is Rietveld 408576698