Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsViewController.m

Issue 2807533004: Address denicija's comments for AppRTCMobile video codec setting. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/examples/objc/AppRTCMobile/ARDSettingsModel.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 - (void)viewWillAppear:(BOOL)animated { 47 - (void)viewWillAppear:(BOOL)animated {
48 [super viewWillAppear:animated]; 48 [super viewWillAppear:animated];
49 [self addCheckmarkInSection:ARDSettingsSectionVideoResolution 49 [self addCheckmarkInSection:ARDSettingsSectionVideoResolution
50 withArray:[self videoResolutionArray] 50 withArray:[self videoResolutionArray]
51 selecting:[_settingsModel currentVideoResolutionSettingFromS tore]]; 51 selecting:[_settingsModel currentVideoResolutionSettingFromS tore]];
52 [self addCheckmarkInSection:ARDSettingsSectionVideoCodec 52 [self addCheckmarkInSection:ARDSettingsSectionVideoCodec
53 withArray:[self videoCodecArray] 53 withArray:[self videoCodecArray]
54 selecting:[_settingsModel currentVideoCodecSettingFromStore] ]; 54 selecting:[_settingsModel currentVideoCodecSettingFromStore] ];
55 } 55 }
56 56
57 - (void)viewDidAppear:(BOOL)animated {
58 [super viewDidAppear:animated];
59 }
60
61 #pragma mark - Data source 57 #pragma mark - Data source
62 58
63 - (NSArray<NSString *> *)videoResolutionArray { 59 - (NSArray<NSString *> *)videoResolutionArray {
64 return _settingsModel.availableVideoResolutions; 60 return _settingsModel.availableVideoResolutions;
65 } 61 }
66 62
67 - (NSArray<NSString *> *)videoCodecArray { 63 - (NSArray<NSString *> *)videoCodecArray {
68 return _settingsModel.availableVideoCodecs; 64 return _settingsModel.availableVideoCodecs;
69 } 65 }
70 66
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 270
275 if (textField.text.length != 0) { 271 if (textField.text.length != 0) {
276 bitrateNumber = [NSNumber numberWithInteger:textField.text.intValue]; 272 bitrateNumber = [NSNumber numberWithInteger:textField.text.intValue];
277 } 273 }
278 274
279 [_settingsModel storeMaxBitrateSetting:bitrateNumber]; 275 [_settingsModel storeMaxBitrateSetting:bitrateNumber];
280 } 276 }
281 277
282 @end 278 @end
283 NS_ASSUME_NONNULL_END 279 NS_ASSUME_NONNULL_END
OLDNEW
« no previous file with comments | « webrtc/examples/objc/AppRTCMobile/ARDSettingsModel.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698