Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2806163003: Fix two invalid DCHECKs related to audio BWE. (Closed)

Created:
3 years, 8 months ago by stefan-webrtc
Modified:
3 years, 8 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman, tlegrand-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix two invalid DCHECKs related to audio BWE. These are invalid since: - An allocated bitrate of 0 means that the stream should be disabled. Changing the behavior to send audio at min bitrate even though the allocator asks for the stream to be disabled. - It should be OK to set a min bitrate equal to the start bitrate. BUG=webrtc:5079 Review-Url: https://codereview.webrtc.org/2806163003 Cr-Commit-Position: refs/heads/master@{#17613} Committed: https://chromium.googlesource.com/external/webrtc/+/fca900aa3767bc6800e2119e4135965895b54e2c

Patch Set 1 #

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M webrtc/audio/audio_send_stream.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/call/call.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
stefan-webrtc
3 years, 8 months ago (2017-04-10 09:46:19 UTC) #3
stefan-webrtc
Add comment.
3 years, 8 months ago (2017-04-10 09:47:46 UTC) #4
minyue-webrtc
lgtm
3 years, 8 months ago (2017-04-10 09:52:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2806163003/20001
3 years, 8 months ago (2017-04-10 10:50:23 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 10:53:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/fca900aa3767bc6800e2119e4...

Powered by Google App Engine
This is Rietveld 408576698