Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: webrtc/call/call.cc

Issue 2806163003: Fix two invalid DCHECKs related to audio BWE. (Closed)
Patch Set: Add comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio/audio_send_stream.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 estimated_send_bitrate_kbps_counter_(clock_, nullptr, true), 367 estimated_send_bitrate_kbps_counter_(clock_, nullptr, true),
368 pacer_bitrate_kbps_counter_(clock_, nullptr, true), 368 pacer_bitrate_kbps_counter_(clock_, nullptr, true),
369 remb_(clock_), 369 remb_(clock_),
370 receive_side_cc_(clock_, &remb_, transport_send->packet_router()), 370 receive_side_cc_(clock_, &remb_, transport_send->packet_router()),
371 video_send_delay_stats_(new SendDelayStats(clock_)), 371 video_send_delay_stats_(new SendDelayStats(clock_)),
372 start_ms_(clock_->TimeInMilliseconds()), 372 start_ms_(clock_->TimeInMilliseconds()),
373 worker_queue_("call_worker_queue") { 373 worker_queue_("call_worker_queue") {
374 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread()); 374 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
375 RTC_DCHECK(config.event_log != nullptr); 375 RTC_DCHECK(config.event_log != nullptr);
376 RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0); 376 RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0);
377 RTC_DCHECK_GT(config.bitrate_config.start_bitrate_bps, 377 RTC_DCHECK_GE(config.bitrate_config.start_bitrate_bps,
378 config.bitrate_config.min_bitrate_bps); 378 config.bitrate_config.min_bitrate_bps);
379 if (config.bitrate_config.max_bitrate_bps != -1) { 379 if (config.bitrate_config.max_bitrate_bps != -1) {
380 RTC_DCHECK_GE(config.bitrate_config.max_bitrate_bps, 380 RTC_DCHECK_GE(config.bitrate_config.max_bitrate_bps,
381 config.bitrate_config.start_bitrate_bps); 381 config.bitrate_config.start_bitrate_bps);
382 } 382 }
383 Trace::CreateTrace(); 383 Trace::CreateTrace();
384 transport_send->RegisterNetworkObserver(this); 384 transport_send->RegisterNetworkObserver(this);
385 transport_send_ = std::move(transport_send); 385 transport_send_ = std::move(transport_send);
386 transport_send_->send_side_cc()->SignalNetworkState(kNetworkDown); 386 transport_send_->send_side_cc()->SignalNetworkState(kNetworkDown);
387 transport_send_->send_side_cc()->SetBweBitrates( 387 transport_send_->send_side_cc()->SetBweBitrates(
(...skipping 934 matching lines...) Expand 10 before | Expand all | Expand 10 after
1322 (use_send_side_bwe && header.extension.hasTransportSequenceNumber)) { 1322 (use_send_side_bwe && header.extension.hasTransportSequenceNumber)) {
1323 receive_side_cc_.OnReceivedPacket( 1323 receive_side_cc_.OnReceivedPacket(
1324 packet.arrival_time_ms(), packet.payload_size() + packet.padding_size(), 1324 packet.arrival_time_ms(), packet.payload_size() + packet.padding_size(),
1325 header); 1325 header);
1326 } 1326 }
1327 } 1327 }
1328 1328
1329 } // namespace internal 1329 } // namespace internal
1330 1330
1331 } // namespace webrtc 1331 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/audio/audio_send_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698