Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2800633004: Resolve dependency between rtc_event_log_api and remote_bitrate_estimator (Closed)

Created:
3 years, 8 months ago by michaelt
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Resolve dependency between rtc_event_log_api and remote_bitrate_estimator BUG=webrtc:7257 Review-Url: https://codereview.webrtc.org/2800633004 Cr-Commit-Position: refs/heads/master@{#17638} Committed: https://chromium.googlesource.com/external/webrtc/+/97653704161c670d938ca7479361210fe0df5c11

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -66 lines) Patch
M webrtc/logging/BUILD.gn View 1 4 chunks +3 lines, -6 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc View 19 chunks +22 lines, -22 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (22 generated)
michaelt
Here the follow up to https://codereview.webrtc.org/2745473003.
3 years, 8 months ago (2017-04-06 12:26:56 UTC) #3
terelius
lgtm
3 years, 8 months ago (2017-04-06 12:35:50 UTC) #4
kjellander_webrtc
lgtm
3 years, 8 months ago (2017-04-06 12:44:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2800633004/20001
3 years, 8 months ago (2017-04-11 07:47:09 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 07:49:49 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/97653704161c670d938ca7479...

Powered by Google App Engine
This is Rietveld 408576698