Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: webrtc/logging/BUILD.gn

Issue 2800633004: Resolve dependency between rtc_event_log_api and remote_bitrate_estimator (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/rtc_event_log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/logging/BUILD.gn
diff --git a/webrtc/logging/BUILD.gn b/webrtc/logging/BUILD.gn
index 11c816e11b81c63017d041ef8ded74ef4cc665d9..6fcab59435a053a183a0ec73d4438b9d03df387e 100644
--- a/webrtc/logging/BUILD.gn
+++ b/webrtc/logging/BUILD.gn
@@ -23,12 +23,6 @@ group("logging") {
}
rtc_source_set("rtc_event_log_api") {
- # TODO(kjellander): Remove (bugs.webrtc.org/7257)
- # Enabling GN check triggers cyclic dependency error:
- # //webrtc/logging:rtc_event_log_api ->
- # //webrtc/modules/audio_coding:audio_network_adaptor ->
- # //webrtc/logging:rtc_event_log_api
- check_includes = false
sources = [
"rtc_event_log/rtc_event_log.h",
]
@@ -55,6 +49,7 @@ rtc_static_library("rtc_event_log_impl") {
"../base:rtc_base_approved",
"../call:call_interfaces",
"../modules/audio_coding:audio_network_adaptor",
+ "../modules/remote_bitrate_estimator:remote_bitrate_estimator",
"../modules/rtp_rtcp",
"../system_wrappers",
]
@@ -89,6 +84,7 @@ if (rtc_enable_protobuf) {
"..:webrtc_common",
"../call:call_interfaces",
"../modules/audio_coding:audio_network_adaptor",
+ "../modules/remote_bitrate_estimator:remote_bitrate_estimator",
"../modules/rtp_rtcp:rtp_rtcp",
"../system_wrappers",
]
@@ -118,6 +114,7 @@ if (rtc_enable_protobuf) {
"../base:rtc_base_tests_utils",
"../call",
"../modules/audio_coding:audio_network_adaptor",
+ "../modules/remote_bitrate_estimator:remote_bitrate_estimator",
"../modules/rtp_rtcp",
"../system_wrappers:metrics_default",
"../test:test_support",
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/rtc_event_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698