Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Issue 2800403003: Revert of Add first part of the network_tester functionality. (Closed)

Created:
3 years, 8 months ago by michaelt
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, terelius
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add first part of the network_tester functionality. (patchset #13 id:260001 of https://codereview.webrtc.org/2779233002/ ) Reason for revert: Tasn test failure. Original issue's description: > Add first part of the network_tester functionality. > > BUG=webrtc:7426 > > Review-Url: https://codereview.webrtc.org/2779233002 > Cr-Commit-Position: refs/heads/master@{#17635} > Committed: https://chromium.googlesource.com/external/webrtc/+/333d0ff63173f2561fb03b323080e5f8b1c71dc4 TBR=stefan@webrtc.org,minyue@webrtc.org,nisse@webrtc.org,terelius@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7426 Review-Url: https://codereview.webrtc.org/2800403003 Cr-Commit-Position: refs/heads/master@{#17636} Committed: https://chromium.googlesource.com/external/webrtc/+/7fb7bbd1798931a9c6c0b3d29e26466419583e54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -678 lines) Patch
D resources/network_tester/client_config.dat.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D resources/network_tester/server_config.dat.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/tools/network_tester/BUILD.gn View 1 chunk +0 lines, -93 lines 0 comments Download
D webrtc/tools/network_tester/config_reader.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/tools/network_tester/config_reader.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/tools/network_tester/create_network_tester_config.py View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/tools/network_tester/network_tester_config.proto View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/tools/network_tester/network_tester_packet.proto View 1 chunk +0 lines, -18 lines 0 comments Download
D webrtc/tools/network_tester/network_tester_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/tools/network_tester/packet_sender.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/tools/network_tester/packet_sender.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D webrtc/tools/network_tester/test_controller.h View 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/tools/network_tester/test_controller.cc View 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
michaelt
Created Revert of Add first part of the network_tester functionality.
3 years, 8 months ago (2017-04-11 07:16:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2800403003/1
3 years, 8 months ago (2017-04-11 07:16:46 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 07:16:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7fb7bbd1798931a9c6c0b3d29...

Powered by Google App Engine
This is Rietveld 408576698