Removing unnecessary parameters from initializeAndroidGlobals.

Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time were required to be true, causing a lot of confusion.
This CL removes them, but leaves the old method signature around,
marked "deprecated".

BUG=webrtc:3416
TBR=solenberg@webrtc.org

Review-Url: https://codereview.webrtc.org/2800353002
Cr-Commit-Position: refs/heads/master@{#17626}
Committed: https://chromium.googlesource.com/external/webrtc/+/b4fc73a3ab9ff6014fa3ff68d4f71a7ae6e67e36

[Taylor Brandstetter, 2017-04-10 04:41:11]

Description was changed from

==========
Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time are required to be true, causing a lot of confusion.
This CL removes them, and leaves the old method around, marked
"deprecated".

BUG=webrtc:3416
==========

to

==========
Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time were required to be true, causing a lot of confusion.
This CL removes them, and leaves the old method around, marked
"deprecated".

BUG=webrtc:3416
==========

[Taylor Brandstetter, 2017-04-10 04:41:56]

deadbeef@webrtc.org changed reviewers:
+ magjed@webrtc.org, solenberg@webrtc.org

[Taylor Brandstetter, 2017-04-10 04:41:56]

magjed: PTAL
solenberg: PTAL at voice_engine changes

[Taylor Brandstetter, 2017-04-10 04:42:02]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 04:42:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 05:05:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 05:05:07]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-04-10 10:27:57]

lgtm. Thanks for doing this cleanup!

https://codereview.webrtc.org/2800353002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java (right):

https://codereview.webrtc.org/2800353002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java:57: // untyped here
to allow building on non-Android platforms.
Actually, we don't support non-Android platforms anymore. Can you take the
opportunity to change it to android.content.Context here?

[Taylor Brandstetter, 2017-04-10 17:55:27]

Description was changed from

==========
Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time were required to be true, causing a lot of confusion.
This CL removes them, and leaves the old method around, marked
"deprecated".

BUG=webrtc:3416
==========

to

==========
Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time were required to be true, causing a lot of confusion.
This CL removes them, but leaves the old method signature around,
marked "deprecated".

BUG=webrtc:3416
==========

[Taylor Brandstetter, 2017-04-10 17:56:46]

https://codereview.webrtc.org/2800353002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java (right):

https://codereview.webrtc.org/2800353002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java:57: // untyped here
to allow building on non-Android platforms.
On 2017/04/10 10:27:56, magjed_webrtc wrote:
> Actually, we don't support non-Android platforms anymore. Can you take the
> opportunity to change it to android.content.Context here?

Done.

[Taylor Brandstetter, 2017-04-10 17:57:02]

Description was changed from

==========
Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time were required to be true, causing a lot of confusion.
This CL removes them, but leaves the old method signature around,
marked "deprecated".

BUG=webrtc:3416
==========

to

==========
Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time were required to be true, causing a lot of confusion.
This CL removes them, but leaves the old method signature around,
marked "deprecated".

BUG=webrtc:3416
TBR=solenberg@webrtc.org
==========

[Taylor Brandstetter, 2017-04-10 17:57:09]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-04-10 17:57:10]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2800353002/#ps20001 (title:
"Change type of "context" to an actual Android context.")

[commit-bot: I haz the power, 2017-04-10 17:57:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 19:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:57:48]

Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build hasn't started
yet, builder probably lacks capacity)

[Taylor Brandstetter, 2017-04-10 22:04:22]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-04-10 22:04:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 22:08:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491861862141180,
"parent_rev": "6799553a2cbe2470115a7db01ed14f4a4c593d88", "commit_rev":
"b4fc73a3ab9ff6014fa3ff68d4f71a7ae6e67e36"}

[commit-bot: I haz the power, 2017-04-10 22:08:07]

Description was changed from

==========
Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time were required to be true, causing a lot of confusion.
This CL removes them, but leaves the old method signature around,
marked "deprecated".

BUG=webrtc:3416
TBR=solenberg@webrtc.org
==========

to

==========
Removing unnecessary parameters from initializeAndroidGlobals.

The "initialize audio/video" parameters are no longer needed, but
at the same time were required to be true, causing a lot of confusion.
This CL removes them, but leaves the old method signature around,
marked "deprecated".

BUG=webrtc:3416
TBR=solenberg@webrtc.org

Review-Url: https://codereview.webrtc.org/2800353002
Cr-Commit-Position: refs/heads/master@{#17626}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b4fc73a3ab9ff6014fa3ff68d...
==========

[commit-bot: I haz the power, 2017-04-10 22:08:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/b4fc73a3ab9ff6014fa3ff68d...

[the sun, 2017-04-11 21:11:39]

LGTM! Nice, thank you! I thought there were possibly downstream dependencies,
but it seems they must be gone.

[Taylor Brandstetter, 2017-04-11 22:01:05]

On 2017/04/11 21:11:39, the sun wrote:
> LGTM! Nice, thank you! I thought there were possibly downstream dependencies,
> but it seems they must be gone.

There actually were... I ended up doing this:
https://codereview.webrtc.org/2810973002/

But I think everything should be resolved by the end of the day.

[henrika_webrtc, 2017-04-18 10:34:26]

lgtm. Thanks for fixing!