Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java

Issue 2800353002: Removing unnecessary parameters from initializeAndroidGlobals. (Closed)
Patch Set: Change type of "context" to an actual Android context. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/pc/test/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2014 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 } 464 }
465 465
466 @Override 466 @Override
467 public void onWebRtcAudioRecordError(String errorMessage) { 467 public void onWebRtcAudioRecordError(String errorMessage) {
468 Log.e(TAG, "onWebRtcAudioRecordError: " + errorMessage); 468 Log.e(TAG, "onWebRtcAudioRecordError: " + errorMessage);
469 reportError(errorMessage); 469 reportError(errorMessage);
470 } 470 }
471 }); 471 });
472 472
473 // Create peer connection factory. 473 // Create peer connection factory.
474 if (!PeerConnectionFactory.initializeAndroidGlobals( 474 PeerConnectionFactory.initializeAndroidGlobals(
475 context, true, true, peerConnectionParameters.videoCodecHwAccelerati on)) { 475 context, peerConnectionParameters.videoCodecHwAcceleration);
476 events.onPeerConnectionError("Failed to initializeAndroidGlobals");
477 }
478 if (options != null) { 476 if (options != null) {
479 Log.d(TAG, "Factory networkIgnoreMask option: " + options.networkIgnoreMas k); 477 Log.d(TAG, "Factory networkIgnoreMask option: " + options.networkIgnoreMas k);
480 } 478 }
481 factory = new PeerConnectionFactory(options); 479 factory = new PeerConnectionFactory(options);
482 Log.d(TAG, "Peer connection factory created."); 480 Log.d(TAG, "Peer connection factory created.");
483 } 481 }
484 482
485 private void createMediaConstraintsInternal() { 483 private void createMediaConstraintsInternal() {
486 // Create peer connection constraints. 484 // Create peer connection constraints.
487 pcConstraints = new MediaConstraints(); 485 pcConstraints = new MediaConstraints();
(...skipping 835 matching lines...) Expand 10 before | Expand all | Expand 10 after
1323 public void onCreateFailure(final String error) { 1321 public void onCreateFailure(final String error) {
1324 reportError("createSDP error: " + error); 1322 reportError("createSDP error: " + error);
1325 } 1323 }
1326 1324
1327 @Override 1325 @Override
1328 public void onSetFailure(final String error) { 1326 public void onSetFailure(final String error) {
1329 reportError("setSDP error: " + error); 1327 reportError("setSDP error: " + error);
1330 } 1328 }
1331 } 1329 }
1332 } 1330 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/pc/test/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698