Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2799783005: Revert of Enable rtc_unittests on iOS simulator (Closed)

Created:
3 years, 8 months ago by kjellander_webrtc
Modified:
3 years, 8 months ago
Reviewers:
oprypin_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable rtc_unittests on iOS simulator (patchset #2 id:20001 of https://codereview.webrtc.org/2799033004/ ) Reason for revert: It has already failed several times: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1363 https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1361 https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1360 Original issue's description: > Enable rtc_unittests on iOS simulator > > The recent change in https://codereview.chromium.org/2780513006 > seems to make it possible for us to enable this test. > > BUG=webrtc:5572, webrtc:5566 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2799033004 > Cr-Commit-Position: refs/heads/master@{#17558} > Committed: https://chromium.googlesource.com/external/webrtc/+/4fcfdd8ff07b15b99925e92783272871253cf2e4 TBR=oprypin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5572, webrtc:5566 Review-Url: https://codereview.webrtc.org/2799783005 Cr-Commit-Position: refs/heads/master@{#17567} Committed: https://chromium.googlesource.com/external/webrtc/+/cab8d888c584044a35f56f6b3e1ceecffdb0435e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools-webrtc/ios/tests/common_tests.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
Created Revert of Enable rtc_unittests on iOS simulator
3 years, 8 months ago (2017-04-06 14:32:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2799783005/1
3 years, 8 months ago (2017-04-06 14:32:49 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 14:32:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cab8d888c584044a35f56f6b3...

Powered by Google App Engine
This is Rietveld 408576698