Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2799033004: Enable rtc_unittests on iOS simulator (Closed)

Created:
3 years, 8 months ago by kjellander_webrtc
Modified:
3 years, 8 months ago
Reviewers:
oprypin_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable rtc_unittests on iOS simulator The recent change in https://codereview.chromium.org/2780513006 seems to make it possible for us to enable this test. BUG=webrtc:5572, webrtc:5566 NOTRY=True Review-Url: https://codereview.webrtc.org/2799033004 Cr-Commit-Position: refs/heads/master@{#17558} Committed: https://chromium.googlesource.com/external/webrtc/+/4fcfdd8ff07b15b99925e92783272871253cf2e4

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools-webrtc/ios/tests/common_tests.json View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander_webrtc
3 years, 8 months ago (2017-04-06 08:46:08 UTC) #2
oprypin_webrtc
lgtm. Makes sense to at least try enabling this
3 years, 8 months ago (2017-04-06 08:48:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2799033004/1
3 years, 8 months ago (2017-04-06 09:09:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15814)
3 years, 8 months ago (2017-04-06 09:13:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2799033004/20001
3 years, 8 months ago (2017-04-06 09:19:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/4fcfdd8ff07b15b99925e92783272871253cf2e4
3 years, 8 months ago (2017-04-06 09:21:49 UTC) #13
kjellander_webrtc
3 years, 8 months ago (2017-04-06 14:32:39 UTC) #14

Powered by Google App Engine
This is Rietveld 408576698