Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2798553002: Reland of Export library that generates an HTLM file with the scores organized in tables. (Closed)

Created:
3 years, 8 months ago by AleBzk
Modified:
3 years, 8 months ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Export library that generates an HTLM file with the scores organized in tables. (patchset #1 id:1 of https://codereview.webrtc.org/2791293002/ ) Reason for revert: Relanding https://codereview.webrtc.org/2717973006 BUG=webrtc:7218 Original issue's description: > Revert of Export library that generates an HTLM file with the scores organized in tables. (patchset #3 id:40001 of https://codereview.webrtc.org/2717973006/ ) > > Reason for revert: > Issue with rebasing from depending CL > > Original issue's description: > > Export library that generates an HTLM file with the scores organized in tables. > > > > BUG=webrtc:7218 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717973006 > > Cr-Commit-Position: refs/heads/master@{#17512} > > Committed: https://chromium.googlesource.com/external/webrtc/+/29e3330139ff1dc070aad94e31955a006038d3e4 > > TBR=aleloi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7218 > > Review-Url: https://codereview.webrtc.org/2791293002 > Cr-Commit-Position: refs/heads/master@{#17513} > Committed: https://chromium.googlesource.com/external/webrtc/+/880c85ba7e1692be18d7b56ab4b3db1c98020c32 TBR=aleloi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2798553002 Cr-Commit-Position: refs/heads/master@{#17525} Committed: https://chromium.googlesource.com/external/webrtc/+/8edb8397f810e10afae9ee4e86bf2cd4a6959a19

Patch Set 1 #

Patch Set 2 : reland fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -0 lines) Patch
M webrtc/modules/audio_processing/test/py_quality_assessment/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py View 1 chunk +151 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/export.py View 1 chunk +26 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
AleBzk
Created Reland of Export library that generates an HTLM file with the scores organized in ...
3 years, 8 months ago (2017-04-04 08:01:42 UTC) #1
aleloi
lgtm
3 years, 8 months ago (2017-04-04 09:33:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2798553002/100001
3 years, 8 months ago (2017-04-04 09:36:20 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 09:36:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/8edb8397f810e10afae9ee4e8...

Powered by Google App Engine
This is Rietveld 408576698