Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2791293002: Revert of Export library that generates an HTLM file with the scores organized in tables. (Closed)

Created:
3 years, 8 months ago by AleBzk
Modified:
3 years, 8 months ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Export library that generates an HTLM file with the scores organized in tables. (patchset #3 id:40001 of https://codereview.webrtc.org/2717973006/ ) Reason for revert: Issue with rebasing from depending CL Original issue's description: > Export library that generates an HTLM file with the scores organized in tables. > > BUG=webrtc:7218 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2717973006 > Cr-Commit-Position: refs/heads/master@{#17512} > Committed: https://chromium.googlesource.com/external/webrtc/+/29e3330139ff1dc070aad94e31955a006038d3e4 TBR=aleloi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2791293002 Cr-Commit-Position: refs/heads/master@{#17513} Committed: https://chromium.googlesource.com/external/webrtc/+/880c85ba7e1692be18d7b56ab4b3db1c98020c32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -179 lines) Patch
M webrtc/modules/audio_processing/test/py_quality_assessment/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py View 1 chunk +0 lines, -151 lines 0 comments Download
D webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/export.py View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
AleBzk
Created Revert of Export library that generates an HTLM file with the scores organized in ...
3 years, 8 months ago (2017-04-03 15:46:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2791293002/1
3 years, 8 months ago (2017-04-03 15:46:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/880c85ba7e1692be18d7b56ab4b3db1c98020c32
3 years, 8 months ago (2017-04-03 15:47:02 UTC) #6
aleloi
lgtm
3 years, 8 months ago (2017-04-03 15:49:50 UTC) #7
AleBzk
3 years, 8 months ago (2017-04-04 08:01:41 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2798553002/ by alessiob@webrtc.org.

The reason for reverting is: Relanding https://codereview.webrtc.org/2717973006
.

Powered by Google App Engine
This is Rietveld 408576698