Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2798403003: Hooked up Opus CBR support when configured manually or through an SdpAudioFormat. (Closed)

Created:
3 years, 8 months ago by ossu
Modified:
3 years, 7 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, squashingskak
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Hooked up Opus CBR support when configured manually or through an SdpAudioFormat. BUG=webrtc:7394 Review-Url: https://codereview.webrtc.org/2798403003 Cr-Commit-Position: refs/heads/master@{#17931} Committed: https://chromium.googlesource.com/external/webrtc/+/0d6195dd15390daf6f192f6fd3e14a585925bdf5

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
ossu
The functionality in this one won't be available until the previous CL has landed as ...
3 years, 8 months ago (2017-04-07 14:55:52 UTC) #3
minyue-webrtc
On 2017/04/07 14:55:52, ossu wrote: > The functionality in this one won't be available until ...
3 years, 8 months ago (2017-04-07 14:58:54 UTC) #4
ossu
The CL this depends on has landed and I've uploaded a rebased patchset.
3 years, 7 months ago (2017-04-27 15:47:21 UTC) #7
minyue-webrtc
lgtm
3 years, 7 months ago (2017-04-28 14:28:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2798403003/20001
3 years, 7 months ago (2017-04-28 14:30:48 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 14:33:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0d6195dd15390daf6f192f6fd...

Powered by Google App Engine
This is Rietveld 408576698