Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc

Issue 2798403003: Hooked up Opus CBR support when configured manually or through an SdpAudioFormat. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 565 matching lines...) Expand 10 before | Expand all | Expand 10 after
576 576
577 config = CreateConfigWithParameters({{"useinbandfec", "1"}}); 577 config = CreateConfigWithParameters({{"useinbandfec", "1"}});
578 EXPECT_TRUE(config.fec_enabled); 578 EXPECT_TRUE(config.fec_enabled);
579 579
580 config = CreateConfigWithParameters({{"usedtx", "0"}}); 580 config = CreateConfigWithParameters({{"usedtx", "0"}});
581 EXPECT_FALSE(config.dtx_enabled); 581 EXPECT_FALSE(config.dtx_enabled);
582 582
583 config = CreateConfigWithParameters({{"usedtx", "1"}}); 583 config = CreateConfigWithParameters({{"usedtx", "1"}});
584 EXPECT_TRUE(config.dtx_enabled); 584 EXPECT_TRUE(config.dtx_enabled);
585 585
586 config = CreateConfigWithParameters({{"cbr", "0"}});
587 EXPECT_FALSE(config.cbr_enabled);
588
589 config = CreateConfigWithParameters({{"cbr", "1"}});
590 EXPECT_TRUE(config.cbr_enabled);
591
586 config = CreateConfigWithParameters({{"maxplaybackrate", "12345"}}); 592 config = CreateConfigWithParameters({{"maxplaybackrate", "12345"}});
587 EXPECT_EQ(12345, config.max_playback_rate_hz); 593 EXPECT_EQ(12345, config.max_playback_rate_hz);
588 594
589 config = CreateConfigWithParameters({{"maxaveragebitrate", "96000"}}); 595 config = CreateConfigWithParameters({{"maxaveragebitrate", "96000"}});
590 EXPECT_EQ(96000, config.bitrate_bps); 596 EXPECT_EQ(96000, config.bitrate_bps);
591 597
592 config = CreateConfigWithParameters({{"maxptime", "40"}}); 598 config = CreateConfigWithParameters({{"maxptime", "40"}});
593 for (int frame_length : config.supported_frame_lengths_ms) { 599 for (int frame_length : config.supported_frame_lengths_ms) {
594 EXPECT_LE(frame_length, 40); 600 EXPECT_LE(frame_length, 40);
595 } 601 }
(...skipping 30 matching lines...) Expand all
626 AudioEncoderOpus::Config config; 632 AudioEncoderOpus::Config config;
627 config = CreateConfigWithParameters({{"stereo", "invalid"}}); 633 config = CreateConfigWithParameters({{"stereo", "invalid"}});
628 EXPECT_EQ(default_config.num_channels, config.num_channels); 634 EXPECT_EQ(default_config.num_channels, config.num_channels);
629 635
630 config = CreateConfigWithParameters({{"useinbandfec", "invalid"}}); 636 config = CreateConfigWithParameters({{"useinbandfec", "invalid"}});
631 EXPECT_EQ(default_config.fec_enabled, config.fec_enabled); 637 EXPECT_EQ(default_config.fec_enabled, config.fec_enabled);
632 638
633 config = CreateConfigWithParameters({{"usedtx", "invalid"}}); 639 config = CreateConfigWithParameters({{"usedtx", "invalid"}});
634 EXPECT_EQ(default_config.dtx_enabled, config.dtx_enabled); 640 EXPECT_EQ(default_config.dtx_enabled, config.dtx_enabled);
635 641
642 config = CreateConfigWithParameters({{"cbr", "invalid"}});
643 EXPECT_EQ(default_config.dtx_enabled, config.dtx_enabled);
644
636 config = CreateConfigWithParameters({{"maxplaybackrate", "0"}}); 645 config = CreateConfigWithParameters({{"maxplaybackrate", "0"}});
637 EXPECT_EQ(default_config.max_playback_rate_hz, config.max_playback_rate_hz); 646 EXPECT_EQ(default_config.max_playback_rate_hz, config.max_playback_rate_hz);
638 647
639 config = CreateConfigWithParameters({{"maxplaybackrate", "-23"}}); 648 config = CreateConfigWithParameters({{"maxplaybackrate", "-23"}});
640 EXPECT_EQ(default_config.max_playback_rate_hz, config.max_playback_rate_hz); 649 EXPECT_EQ(default_config.max_playback_rate_hz, config.max_playback_rate_hz);
641 650
642 config = CreateConfigWithParameters({{"maxplaybackrate", "not a number!"}}); 651 config = CreateConfigWithParameters({{"maxplaybackrate", "not a number!"}});
643 EXPECT_EQ(default_config.max_playback_rate_hz, config.max_playback_rate_hz); 652 EXPECT_EQ(default_config.max_playback_rate_hz, config.max_playback_rate_hz);
644 653
645 config = CreateConfigWithParameters({{"maxaveragebitrate", "0"}}); 654 config = CreateConfigWithParameters({{"maxaveragebitrate", "0"}});
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 EXPECT_EQ(24001, config.max_playback_rate_hz); 749 EXPECT_EQ(24001, config.max_playback_rate_hz);
741 EXPECT_EQ(32000, config.bitrate_bps); 750 EXPECT_EQ(32000, config.bitrate_bps);
742 751
743 config = CreateConfigWithParameters({{"maxplaybackrate", "24001"}, 752 config = CreateConfigWithParameters({{"maxplaybackrate", "24001"},
744 {"stereo", "1"}}); 753 {"stereo", "1"}});
745 EXPECT_EQ(24001, config.max_playback_rate_hz); 754 EXPECT_EQ(24001, config.max_playback_rate_hz);
746 EXPECT_EQ(64000, config.bitrate_bps); 755 EXPECT_EQ(64000, config.bitrate_bps);
747 } 756 }
748 757
749 } // namespace webrtc 758 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698