Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2795043004: Use simulcast for screenshare only in conference mode (Closed)

Created:
3 years, 8 months ago by ilnik
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/branch-heads/58
Project:
webrtc
Visibility:
Public.

Description

Use simulcast for screenshare only in conference mode Also, don't crash if InitEncode fails for vp8. BUG=chromium:705505 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2779163002 Cr-Commit-Position: refs/heads/master@{#17452} (cherry picked from commit fe627f30cbd3b4e0665237c7f309973cbf15e30b) Review-Url: https://codereview.webrtc.org/2795043004 Cr-Commit-Position: refs/branch-heads/58@{#16} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} Committed: https://chromium.googlesource.com/external/webrtc/+/5bb66b6e65e11c5031893f731b722d0d7f06c09c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -10 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 4 chunks +50 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
ilnik
Hello, Stefan, this is a merge of Erik's hotfix for crashing bug. This is a ...
3 years, 8 months ago (2017-04-04 12:27:47 UTC) #3
stefan-webrtc
lgtm
3 years, 8 months ago (2017-04-04 19:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2795043004/1
3 years, 8 months ago (2017-04-04 19:14:07 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-04 19:14:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2795043004/1
3 years, 8 months ago (2017-04-04 19:15:07 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 19:15:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5bb66b6e65e11c5031893f731...

Powered by Google App Engine
This is Rietveld 408576698