Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2779163002: Use simulcast for screenshare only in conference mode (Closed)

Created:
3 years, 8 months ago by sprang_webrtc
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use simulcast for screenshare only in conference mode Also, don't crash if InitEncode fails for vp8. BUG=chromium:705505 Review-Url: https://codereview.webrtc.org/2779163002 Cr-Commit-Position: refs/heads/master@{#17452} Committed: https://chromium.googlesource.com/external/webrtc/+/fe627f30cbd3b4e0665237c7f309973cbf15e30b

Patch Set 1 #

Patch Set 2 : Test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -10 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 4 chunks +50 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
sprang_webrtc
3 years, 8 months ago (2017-03-29 08:16:22 UTC) #8
stefan-webrtc
lgtm
3 years, 8 months ago (2017-03-29 15:09:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2779163002/20001
3 years, 8 months ago (2017-03-29 15:21:45 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 15:25:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/fe627f30cbd3b4e0665237c7f...

Powered by Google App Engine
This is Rietveld 408576698