Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2792593002:
Delete unused method OnProbeBitrate. (Closed)
|
Created:
3 years, 8 months ago by nisse-webrtc Modified:
3 years, 8 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDelete unused method OnProbeBitrate.
Appears unused since cl https://codereview.webrtc.org/2378103005.
BUG=None
Review-Url: https://codereview.webrtc.org/2792593002
Cr-Commit-Position: refs/heads/master@{#17500}
Committed: https://chromium.googlesource.com/external/webrtc/+/52a0ce68b8afd059124e6bf9e9dc5f96a37b23bc
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
nisse@webrtc.org changed reviewers: + philipel@webrtc.org, terelius@webrtc.org
This seems to have been left over.
lgtm
lgtm
On 2017/03/31 13:59:11, terelius wrote: > lgtm I'm waiting for the internal bot to complete. And no idea what to think about the windows bot crashes.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491208603929350, "parent_rev":
"3a407eee1cbadda19ac49da4559f7592a8be59a8", "commit_rev":
"52a0ce68b8afd059124e6bf9e9dc5f96a37b23bc"}
Message was sent while issue was closed.
Description was changed from ========== Delete unused method OnProbeBitrate. Appears unused since cl https://codereview.webrtc.org/2378103005. BUG=None ========== to ========== Delete unused method OnProbeBitrate. Appears unused since cl https://codereview.webrtc.org/2378103005. BUG=None Review-Url: https://codereview.webrtc.org/2792593002 Cr-Commit-Position: refs/heads/master@{#17500} Committed: https://chromium.googlesource.com/external/webrtc/+/52a0ce68b8afd059124e6bf9e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/52a0ce68b8afd059124e6bf9e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
