Reland: Fix race / crash in OnNetworkRouteChanged().

Reland: Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
R=terelius@webrtc.org

Committed: https://crrev.com/280de9e1c33efa420fa22496d313c232093e093f
Cr-Commit-Position: refs/heads/master@{#14452}

[stefan-webrtc, 2016-09-29 12:12:54]

Description was changed from

==========
Revert "Revert of Fix race / crash in OnNetworkRouteChanged(). (patchset #5
id:80001 of https://codereview.webrtc.org/2366333003/ )"

This reverts commit 5ec85fbcb7ef7ba0684ae2b69df7f36f118bb31f.

BUG=None
==========

to

==========
Revert "Revert of Fix race / crash in OnNetworkRouteChanged(). (patchset #5
id:80001 of https://codereview.webrtc.org/2366333003/ )"

This reverts commit 5ec85fbcb7ef7ba0684ae2b69df7f36f118bb31f.

BUG=webrtc:6427, webrtc:6422
==========

[stefan-webrtc, 2016-09-29 12:13:38]

Description was changed from

==========
Revert "Revert of Fix race / crash in OnNetworkRouteChanged(). (patchset #5
id:80001 of https://codereview.webrtc.org/2366333003/ )"

This reverts commit 5ec85fbcb7ef7ba0684ae2b69df7f36f118bb31f.

BUG=webrtc:6427, webrtc:6422
==========

to

==========
Reland: Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
Committed: https://crrev.com/fd0d42669204e6dd92a60736bca7ae0196663024
Cr-Commit-Position: refs/heads/master@{#14430}
==========

[stefan-webrtc, 2016-09-29 12:14:38]

stefan@webrtc.org changed reviewers:
+ terelius@webrtc.org

[stefan-webrtc, 2016-09-29 12:14:39]

No clue how this got past the trybots, but now it passes webrtc_perf_tests
locally for me.

[stefan-webrtc, 2016-09-29 13:44:04]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 13:44:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2016-09-29 14:09:48]

LGTM

Could you add a test to catch this type of problems on the trybots?

[stefan-webrtc, 2016-09-29 14:37:14]

Added unittest.

[stefan-webrtc, 2016-09-29 14:37:42]

On 2016/09/29 14:37:14, stefan-webrtc (holmer) wrote:
> Added unittest.

Done. PTAL

[stefan-webrtc, 2016-09-29 14:38:46]

Description was changed from

==========
Reland: Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
Committed: https://crrev.com/fd0d42669204e6dd92a60736bca7ae0196663024
Cr-Commit-Position: refs/heads/master@{#14430}
==========

to

==========
Reland: Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
==========

[stefan-webrtc, 2016-09-29 14:45:27]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 14:45:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2016-09-29 14:45:34]

lgtm

https://codereview.webrtc.org/2378103005/diff/40001/webrtc/modules/congestion...
File webrtc/modules/congestion_controller/transport_feedback_adapter_unittest.cc
(right):

https://codereview.webrtc.org/2378103005/diff/40001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/transport_feedback_adapter_unittest.cc:330:
// Run long enough that we get a valid estimate.
nit: Update comment to clarify that the test doesn't rely on waiting a certain
amount of wall clock time?

[stefan-webrtc, 2016-09-29 14:51:22]

https://codereview.webrtc.org/2378103005/diff/40001/webrtc/modules/congestion...
File webrtc/modules/congestion_controller/transport_feedback_adapter_unittest.cc
(right):

https://codereview.webrtc.org/2378103005/diff/40001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/transport_feedback_adapter_unittest.cc:330:
// Run long enough that we get a valid estimate.
On 2016/09/29 14:45:34, terelius wrote:
> nit: Update comment to clarify that the test doesn't rely on waiting a certain
> amount of wall clock time?

Done.

[stefan-webrtc, 2016-09-30 06:10:11]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2016-09-30 06:10:12]

The patchset sent to the CQ was uploaded after l-g-t-m from terelius@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2378103005/#ps60001 (title:
".")

[commit-bot: I haz the power, 2016-09-30 06:10:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-30 06:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 06:15:11]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[stefan-webrtc, 2016-09-30 08:07:03]

Description was changed from

==========
Reland: Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
==========

to

==========
Reland: Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
R=terelius@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/280de9e1c33efa420fa22496d...
==========

[stefan-webrtc, 2016-09-30 08:07:05]

Committed patchset #4 (id:60001) manually as
280de9e1c33efa420fa22496d313c232093e093f (presubmit successful).

[commit-bot: I haz the power, 2016-09-30 08:07:07]

Description was changed from

==========
Reland: Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
R=terelius@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/280de9e1c33efa420fa22496d...
==========

to

==========
Reland: Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
R=terelius@webrtc.org

Committed: https://crrev.com/280de9e1c33efa420fa22496d313c232093e093f
Cr-Commit-Position: refs/heads/master@{#14452}
==========