webrtc/modules/bitrate_controller/bitrate_controller_impl.h - Issue 2378103005: Reland: Fix race / crash in OnNetworkRouteChanged().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/bitrate_controller_impl.h

Issue 2378103005: Reland: Fix race / crash in OnNetworkRouteChanged(). (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/bitrate_controller/bitrate_controller_impl.h

diff --git a/webrtc/modules/bitrate_controller/bitrate_controller_impl.h b/webrtc/modules/bitrate_controller/bitrate_controller_impl.h

index c8bb10282be5677e0ee9976d1038a0f04c2abe0f..7ee6b19380a2ccfb6ef011d732cfcbba0175978a 100644

--- a/webrtc/modules/bitrate_controller/bitrate_controller_impl.h

+++ b/webrtc/modules/bitrate_controller/bitrate_controller_impl.h

@@ -61,10 +61,7 @@ class BitrateControllerImpl : public BitrateController {

uint8_t* fraction_loss,

int64_t* rtt) override;

- // RemoteBitrateObserver overrides.

- void OnReceiveBitrateChanged(const std::vector<uint32_t>& ssrcs,

- uint32_t bitrate_bps) override;

- void OnProbeBitrate(uint32_t bitrate_bps) override;

+ void OnDelayBasedBweResult(const DelayBasedBwe::Result& result) override;

int64_t TimeUntilNextProcess() override;

void Process() override;