Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2783673002:
Make dummy device succeed at stopping recording/playout. (Closed)
|
Created:
3 years, 8 months ago by Max Morin WebRTC Modified:
3 years, 8 months ago Reviewers:
henrika_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, kjellander_webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMake dummy device succeed at stopping recording/playout.
Makes sense, since it not recording/playing to begin with.
BUG=b/35415663
Review-Url: https://codereview.webrtc.org/2783673002
Cr-Commit-Position: refs/heads/master@{#17423}
Committed: https://chromium.googlesource.com/external/webrtc/+/76cc9be72cee2a2ebfcde38a6cf5a0274c2a641b
Patch Set 1 #
Messages
Total messages: 21 (15 generated)
Description was changed from ========== Make dummy device succeed at stopping recording/playout. BUG= ========== to ========== Make dummy device succeed at stopping recording/playout. BUG= ==========
maxmorin@webrtc.org changed reviewers: + henrika@webrtc.org
The CQ bit was checked by maxmorin@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Make dummy device succeed at stopping recording/playout. BUG= ========== to ========== Make dummy device succeed at stopping recording/playout. Makes sense, since it not recording/playing to begin with. BUG= ==========
Henrika: PTAL
Description was changed from ========== Make dummy device succeed at stopping recording/playout. Makes sense, since it not recording/playing to begin with. BUG= ========== to ========== Make dummy device succeed at stopping recording/playout. Makes sense, since it not recording/playing to begin with. BUG=b/35415663 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/7772)
lgtm
Kjellander: Any clue about the compile failure on Windows https://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/1... Looks related to https://codereview.webrtc.org/2684773002. I'll retry the bots.
The CQ bit was checked by maxmorin@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ok, was just some linker flake. Looks unrelated to this, so I'll commit.
The CQ bit was checked by maxmorin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490710602374980, "parent_rev":
"0248e7c810d40b742574c479ed8e3ba404065298", "commit_rev":
"76cc9be72cee2a2ebfcde38a6cf5a0274c2a641b"}
Message was sent while issue was closed.
Description was changed from ========== Make dummy device succeed at stopping recording/playout. Makes sense, since it not recording/playing to begin with. BUG=b/35415663 ========== to ========== Make dummy device succeed at stopping recording/playout. Makes sense, since it not recording/playing to begin with. BUG=b/35415663 Review-Url: https://codereview.webrtc.org/2783673002 Cr-Commit-Position: refs/heads/master@{#17423} Committed: https://chromium.googlesource.com/external/webrtc/+/76cc9be72cee2a2ebfcde38a6... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/76cc9be72cee2a2ebfcde38a6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
