Experiment-driven configuration of PLR/RPLR-based FecController

Experiment-driven configuration of PLR/RPLR-based FecController

BUG=webrtc:7058
Review-Url: https://codereview.webrtc.org/2684773002
Cr-Commit-Position: refs/heads/master@{#17419}
Committed: https://chromium.googlesource.com/external/webrtc/+/2877048afe3f6fa66b2de09af5238b01368d9f5c

[elad.alon_webrtc.org, 2017-02-07 23:19:00]

Description was changed from

==========
Experiment-driven configuration of PLR/RPLR-based FecController

BUG=webrtc:7058
==========

to

==========
Experiment-driven configuration of PLR/RPLR-based FecController

BUG=webrtc:7058
==========

[elad.alon_webrtc.org, 2017-02-07 23:19:01]

elad.alon@webrtc.org changed reviewers:
+ michaelt@webrtc.org, minyue@webrtc.org, sprang@webrtc.org, stefan@webrtc.org

[elad.alon_webrtc.org, 2017-02-07 23:19:13]

Ready for review.

[michaelt, 2017-03-27 13:52:31]

https://codereview.webrtc.org/2684773002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/audio_network_adaptor/config.proto (right):

https://codereview.webrtc.org/2684773002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/config.proto:78: optional
int32 time_constant_ms = 3;
Isn't FecControllerRplrBased without PL smoothing ?

[elad.alon_webrtc.org, 2017-03-27 14:27:24]

https://codereview.webrtc.org/2684773002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/audio_network_adaptor/config.proto (right):

https://codereview.webrtc.org/2684773002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/config.proto:78: optional
int32 time_constant_ms = 3;
On 2017/03/27 13:52:31, michaelt wrote:
> Isn't FecControllerRplrBased without PL smoothing ?

Right you are. Thanks for catching.

[elad.alon_webrtc.org, 2017-03-27 15:57:35]

Piggy-backed the removal of the smoothing parameter on this CL.
Anything else?

[minyue-webrtc, 2017-03-27 18:44:52]

https://codereview.webrtc.org/2684773002/diff/60001/webrtc/modules/audio_codi...
File
webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc
(right):

https://codereview.webrtc.org/2684773002/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc:39:
clock(clock) {}
do you need clock then?

[elad.alon_webrtc.org, 2017-03-27 20:12:32]

https://codereview.webrtc.org/2684773002/diff/60001/webrtc/modules/audio_codi...
File
webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc
(right):

https://codereview.webrtc.org/2684773002/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.cc:39:
clock(clock) {}
On 2017/03/27 18:44:52, minyue-webrtc wrote:
> do you need clock then?

No. Removed.

[minyue-webrtc, 2017-03-27 20:14:25]

lgtm

[michaelt, 2017-03-28 06:50:35]

lgtm

[elad.alon_webrtc.org, 2017-03-28 07:38:49]

The CQ bit was checked by elad.alon@webrtc.org

[commit-bot: I haz the power, 2017-03-28 07:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-28 07:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 07:43:27]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15438)

[elad.alon_webrtc.org, 2017-03-28 09:34:55]

elad.alon@webrtc.org changed reviewers:
+ ossu@webrtc.org, solenberg@webrtc.org

[elad.alon_webrtc.org, 2017-03-28 09:34:56]

Osker/Fredrick, could one of you please accept?

[the sun, 2017-03-28 11:16:42]

LGTM for voice_engine/

[elad.alon_webrtc.org, 2017-03-28 12:01:39]

The CQ bit was checked by elad.alon@webrtc.org

[commit-bot: I haz the power, 2017-03-28 12:01:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-28 12:03:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490702499778600,
"parent_rev": "9c47b00e24da2941eb095df5a4459c6d98a8a88d", "commit_rev":
"2877048afe3f6fa66b2de09af5238b01368d9f5c"}

[commit-bot: I haz the power, 2017-03-28 12:03:57]

Description was changed from

==========
Experiment-driven configuration of PLR/RPLR-based FecController

BUG=webrtc:7058
==========

to

==========
Experiment-driven configuration of PLR/RPLR-based FecController

BUG=webrtc:7058

Review-Url: https://codereview.webrtc.org/2684773002
Cr-Commit-Position: refs/heads/master@{#17419}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2877048afe3f6fa66b2de09af...
==========

[commit-bot: I haz the power, 2017-03-28 12:03:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/2877048afe3f6fa66b2de09af...