Experiment-driven configuration of PLR/RPLR-based FecController

webrtc/modules/audio_coding/audio_network_adaptor/config.proto

 syntax = "proto2";
 option optimize_for = LITE_RUNTIME;
 option java_package = "org.webrtc.AudioNetworkAdaptor";
 option java_outer_classname = "Config";
 package webrtc.audio_network_adaptor.config;
 
 message FecController {
   message Threshold {
     // Threshold defines a curve in the bandwidth/packet-loss domain. The
     // curve is characterized by the two conjunction points: A and B.
@@ skipping 21 matching lines @@
   //             | OFF  \_________ fec_disabling_threshold
   //             |-----------------> bandwidth
   optional Threshold fec_enabling_threshold = 1;
   optional Threshold fec_disabling_threshold = 2;
 
   // |time_constant_ms| is the time constant for an exponential filter, which
   // is used for smoothing the packet loss fraction.
   optional int32 time_constant_ms = 3;
 }
 
+message FecControllerRplrBased {
+  message Threshold {
+    // Threshold defines a curve in the bandwidth/recoverable-packet-loss
+    // domain.
+    // The curve is characterized by the two conjunction points: A and B.
+    //
+    // recoverable ^
+    // packet      |  |
+    //  loss       | A|
+    //             |   \        A: (low_bandwidth_bps,
+    //             |    \           low_bandwidth_recoverable_packet_loss)
+    //             |     \       B: (high_bandwidth_bps,
+    //             |      \          high_bandwidth_recoverable_packet_loss)
+    //             |      B\________
+    //             |---------------> bandwidth
+    optional int32 low_bandwidth_bps = 1;
+    optional float low_bandwidth_recoverable_packet_loss = 2;
+    optional int32 high_bandwidth_bps = 3;
+    optional float high_bandwidth_recoverable_packet_loss = 4;
+  }
+
+  // |fec_enabling_threshold| defines a curve, above which FEC should be
+  // enabled. |fec_disabling_threshold| defines a curve, under which FEC
+  // should be disabled. See below
+  //
+  // packet-loss ^   |  |
+  //             |   |  |   FEC
+  //             |    \  \   ON
+  //             | FEC \  \_______ fec_enabling_threshold
+  //             | OFF  \_________ fec_disabling_threshold
+  //             |-----------------> bandwidth
+  optional Threshold fec_enabling_threshold = 1;
+  optional Threshold fec_disabling_threshold = 2;
+
+  // |time_constant_ms| is the time constant for an exponential filter, which
+  // is used for smoothing the packet loss fraction.
+  optional int32 time_constant_ms = 3;

[michaelt, 2017/03/27 13:52:31]

Isn't FecControllerRplrBased without PL smoothing ?

[elad.alon_webrtc.org, 2017/03/27 14:27:24]

Right you are. Thanks for catching.

+}
+
 message FrameLengthController {
   // Uplink packet loss fraction below which frame length can increase.
   optional float fl_increasing_packet_loss_fraction = 1;
 
   // Uplink packet loss fraction above which frame length should decrease.
   optional float fl_decreasing_packet_loss_fraction = 2;
 
   // Uplink bandwidth below which frame length can switch from 20ms to 60ms.
   optional int32 fl_20ms_to_60ms_bandwidth_bps = 3;
 
@@ skipping 42 matching lines @@
   // without |scoring_point| follow their default order in
   // |ControllerManager::controllers|.
   optional ScoringPoint scoring_point = 1;
 
   oneof controller {
     FecController fec_controller = 21;
     FrameLengthController frame_length_controller = 22;
     ChannelController channel_controller = 23;
     DtxController dtx_controller = 24;
     BitrateController bitrate_controller = 25;
+    FecControllerRplrBased fec_controller_rplr_based = 26;
   }
 }
 
 message ControllerManager {
   repeated Controller controllers = 1;
 
   // Least time since last reordering for a new reordering to be made.
   optional int32 min_reordering_time_ms = 2;
 
   // Least squared distance from last scoring point for a new reordering to be
   // made.
   optional float min_reordering_squared_distance = 3;
 }