Fixing some case-sensitive codec name comparisons.

Fixing some case-sensitive codec name comparisons.

As specified in RFC 4288, Section 4.2, and RFC 4855, Section 3, these
names should be case-insensitive. They already were being treated as
case-insensitive in some other places.

This bug was resulting in either a crash or no decoded video, depending
on the platform.

BUG=webrtc:6439, webrtc:7027
Review-Url: https://codereview.webrtc.org/2782273002
Cr-Commit-Position: refs/heads/master@{#17515}
Committed: https://chromium.googlesource.com/external/webrtc/+/c964d0b3fa6b3d7a5b51a1d4e8ebfeec56e19dc0

[Taylor Brandstetter, 2017-03-29 20:35:14]

deadbeef@webrtc.org changed reviewers:
+ sprang@webrtc.org

[Taylor Brandstetter, 2017-03-29 20:35:14]

PTAL. I plan to add an end-to-end regression test for this, but I'm in the
middle of rewriting the PeerConnection tests
(https://codereview.webrtc.org/2738353003/) so I'm going to finish that first.

[mflodman, 2017-03-30 07:30:14]

mflodman@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[mflodman, 2017-03-30 07:30:14]

LGTM

[sprang_webrtc, 2017-03-30 08:14:47]

lgtm with nit

https://codereview.webrtc.org/2782273002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/2782273002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.cc:150: codec.codecType = codecType ?
*codecType : kVideoCodecGeneric;
You can simplify this to
codec.codecType =
PayloadNameToCodecType(decoder.payload_name).value_or(kVideoCodecGeneric);

[Taylor Brandstetter, 2017-03-30 17:04:33]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-03-30 17:04:33]

Added test as promised; pthatcher, can you take a look at the test?

https://codereview.webrtc.org/2782273002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/2782273002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.cc:150: codec.codecType = codecType ?
*codecType : kVideoCodecGeneric;
On 2017/03/30 08:14:47, språng wrote:
> You can simplify this to
> codec.codecType =
> PayloadNameToCodecType(decoder.payload_name).value_or(kVideoCodecGeneric);

Forgot about that; done.

[pthatcher1, 2017-04-02 05:49:40]

lgtm

[Taylor Brandstetter, 2017-04-03 16:40:58]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-04-03 16:40:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org,
mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2782273002/#ps60001 (title:
"Adding PeerConnection integration test for codec name casing.")

[commit-bot: I haz the power, 2017-04-03 16:41:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-03 17:03:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491237658678870,
"parent_rev": "716d7ac5c1ed6e392e264b34065800bbf03772b3", "commit_rev":
"c964d0b3fa6b3d7a5b51a1d4e8ebfeec56e19dc0"}

[commit-bot: I haz the power, 2017-04-03 17:03:38]

Description was changed from

==========
Fixing some case-sensitive codec name comparisons.

As specified in RFC 4288, Section 4.2, and RFC 4855, Section 3, these
names should be case-insensitive. They already were being treated as
case-insensitive in some other places.

This bug was resulting in either a crash or no decoded video, depending
on the platform.

BUG=webrtc:6439, webrtc:7027
==========

to

==========
Fixing some case-sensitive codec name comparisons.

As specified in RFC 4288, Section 4.2, and RFC 4855, Section 3, these
names should be case-insensitive. They already were being treated as
case-insensitive in some other places.

This bug was resulting in either a crash or no decoded video, depending
on the platform.

BUG=webrtc:6439, webrtc:7027

Review-Url: https://codereview.webrtc.org/2782273002
Cr-Commit-Position: refs/heads/master@{#17515}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c964d0b3fa6b3d7a5b51a1d4e...
==========

[commit-bot: I haz the power, 2017-04-03 17:03:39]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/c964d0b3fa6b3d7a5b51a1d4e...