Fixing some case-sensitive codec name comparisons.

webrtc/pc/peerconnection_integrationtest.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 227 matching lines @@
 
   // Set a callback to be invoked when SDP is received via the fake signaling
   // channel, which provides an opportunity to munge (modify) the SDP. This is
   // used to test SDP being applied that a PeerConnection would normally not
   // generate, but a non-JSEP endpoint might.
   void SetReceivedSdpMunger(
       std::function<void(cricket::SessionDescription*)> munger) {
     received_sdp_munger_ = munger;
   }
 
-  // Siimlar to the above, but this is run on SDP immediately after it's
+  // Similar to the above, but this is run on SDP immediately after it's
   // generated.
   void SetGeneratedSdpMunger(
       std::function<void(cricket::SessionDescription*)> munger) {
     generated_sdp_munger_ = munger;
   }
 
   // Number of times the gathering state has transitioned to "gathering".
   // Useful for telling if an ICE restart occurred as expected.
   int transitions_to_gathering_state() const {
     return transitions_to_gathering_state_;
@@ skipping 2435 matching lines @@
                webrtc::PeerConnectionInterface::kIceConnectionConnected ||
            caller()->ice_connection_state() ==
                webrtc::PeerConnectionInterface::kIceConnectionCompleted),
       total_connection_time_ms, fake_clock);
   // Need to free the clients here since they're using things we created on
   // the stack.
   delete SetCallerPcWrapperAndReturnCurrent(nullptr);
   delete SetCalleePcWrapperAndReturnCurrent(nullptr);
 }
 
+// Test that audio and video flow end-to-end when codec names don't use the
+// expected casing, given that they're supposed to be case insensitive. To test
+// this, all but one codec is removed from each media description, and its
+// casing is changed.
+//
+// In the past, this has regressed and caused crashes/black video, due to the
+// fact that code at some layers was doing case-insensitive comparisons and
+// code at other layers was not.
+TEST_F(PeerConnectionIntegrationTest, CodecNamesAreCaseInsensitive) {
+  ASSERT_TRUE(CreatePeerConnectionWrappers());
+  ConnectFakeSignaling();
+  caller()->AddAudioVideoMediaStream();
+  callee()->AddAudioVideoMediaStream();
+
+  // Remove all but one audio/video codec (opus and VP8), and change the
+  // casing of the caller's generated offer.
+  caller()->SetGeneratedSdpMunger([](cricket::SessionDescription* description) {
+    cricket::AudioContentDescription* audio =
+        GetFirstAudioContentDescription(description);
+    ASSERT_NE(nullptr, audio);
+    auto audio_codecs = audio->codecs();
+    audio_codecs.erase(std::remove_if(audio_codecs.begin(), audio_codecs.end(),
+                                      [](const cricket::AudioCodec& codec) {
+                                        return codec.name != "opus";
+                                      }),
+                       audio_codecs.end());
+    ASSERT_EQ(1u, audio_codecs.size());
+    audio_codecs[0].name = "OpUs";
+    audio->set_codecs(audio_codecs);
+
+    cricket::VideoContentDescription* video =
+        GetFirstVideoContentDescription(description);
+    ASSERT_NE(nullptr, video);
+    auto video_codecs = video->codecs();
+    video_codecs.erase(std::remove_if(video_codecs.begin(), video_codecs.end(),
+                                      [](const cricket::VideoCodec& codec) {
+                                        return codec.name != "VP8";
+                                      }),
+                       video_codecs.end());
+    ASSERT_EQ(1u, video_codecs.size());
+    video_codecs[0].name = "vP8";
+    video->set_codecs(video_codecs);
+  });
+
+  caller()->CreateAndSetAndSignalOffer();
+  ASSERT_TRUE_WAIT(SignalingStateStable(), kDefaultTimeout);
+
+  // Verify frames are still received end-to-end.
+  ExpectNewFramesReceivedWithWait(
+      kDefaultExpectedAudioFrameCount, kDefaultExpectedVideoFrameCount,
+      kDefaultExpectedAudioFrameCount, kDefaultExpectedVideoFrameCount,
+      kMaxWaitForFramesMs);
+}
+
 }  // namespace
 
 #endif  // if !defined(THREAD_SANITIZER)