Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2780783004: Fix issue with conflicting behavior if setting a max BW with b=AS on both audio and video. (Closed)

Created:
3 years, 8 months ago by stefan-webrtc
Modified:
3 years, 8 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/branch-heads/58
Project:
webrtc
Visibility:
Public.

Description

Fix issue with conflicting behavior if setting a max BW with b=AS on both audio and video. This reverts to previous behavior where b=AS only affects the codec bitrate for audio streams, and not the max bandwidth estimate. BUG=chromium:703903 TBR=minyue@webrtc.org Review-Url: https://codereview.webrtc.org/2774123002 Cr-Original-Commit-Position: refs/heads/master@{#17386} Review-Url: https://codereview.webrtc.org/2780783004 . Cr-Commit-Position: refs/branch-heads/58@{#9} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} Committed: https://chromium.googlesource.com/external/webrtc/+/0e43e9d0d6a2f8472c4f47c6fead5415d5472bf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 4 chunks +4 lines, -10 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
stefan-webrtc
3 years, 8 months ago (2017-03-28 20:23:18 UTC) #3
stefan-webrtc
3 years, 8 months ago (2017-03-28 20:26:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e43e9d0d6a2f8472c4f47c6fead5415d5472bf1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698