Fix issue with conflicting behavior if setting a max BW with b=AS on both audio and video.

Fix issue with conflicting behavior if setting a max BW with b=AS on both audio and video.

This reverts to previous behavior where b=AS only affects the codec bitrate for audio streams, and not the max bandwidth estimate.

BUG=chromium:703903
Review-Url: https://codereview.webrtc.org/2774123002
Cr-Commit-Position: refs/heads/master@{#17386}
Committed: https://chromium.googlesource.com/external/webrtc/+/1ccf73f830fd3f4ca75b0e4fd15adc784991edaa

[stefan-webrtc, 2017-03-25 10:42:46]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 10:42:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[stefan-webrtc, 2017-03-25 10:43:32]

stefan@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, minyue@webrtc.org, solenberg@webrtc.org

[commit-bot: I haz the power, 2017-03-25 11:26:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 11:26:50]

Dry run: This issue passed the CQ dry run.

[minyue-webrtc, 2017-03-27 09:22:06]

https://codereview.webrtc.org/2774123002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2774123002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:1641:
call_->SetBitrateConfig(bitrate_config_);
I think there is no need to call this if we remove resetting of bitrate_config_

we may move this to  SetSendCodecs(), and the need of bitrate_config_ as member
var goes away.

[stefan-webrtc, 2017-03-27 10:09:56]

Comment addressed

[stefan-webrtc, 2017-03-27 10:10:27]

https://codereview.webrtc.org/2774123002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2774123002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:1641:
call_->SetBitrateConfig(bitrate_config_);
On 2017/03/27 09:22:06, minyue-webrtc wrote:
> I think there is no need to call this if we remove resetting of
bitrate_config_
> 
> we may move this to  SetSendCodecs(), and the need of bitrate_config_ as
member
> var goes away.

Done.

[minyue-webrtc, 2017-03-27 10:11:27]

lgtm

[stefan-webrtc, 2017-03-27 10:28:38]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2017-03-27 10:28:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-27 10:51:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490610518522060,
"parent_rev": "64f573bbb80ebc6d295c4479f6ef6b2b35105a29", "commit_rev":
"1ccf73f830fd3f4ca75b0e4fd15adc784991edaa"}

[commit-bot: I haz the power, 2017-03-27 10:51:22]

Description was changed from

==========
Fix issue with conflicting behavior if setting a max BW with b=AS on both audio
and video.

This reverts to previous behavior where b=AS only affects the codec bitrate for
audio streams, and not the max bandwidth estimate.

BUG=chromium:703903
==========

to

==========
Fix issue with conflicting behavior if setting a max BW with b=AS on both audio
and video.

This reverts to previous behavior where b=AS only affects the codec bitrate for
audio streams, and not the max bandwidth estimate.

BUG=chromium:703903

Review-Url: https://codereview.webrtc.org/2774123002
Cr-Commit-Position: refs/heads/master@{#17386}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1ccf73f830fd3f4ca75b0e4fd...
==========

[commit-bot: I haz the power, 2017-03-27 10:51:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1ccf73f830fd3f4ca75b0e4fd...

[Taylor Brandstetter, 2017-03-27 21:09:39]

lgtm

[the sun, 2017-04-04 20:05:15]

lgtm