Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 2774123002: Fix issue with conflicting behavior if setting a max BW with b=AS on both audio and video. (Closed)
Patch Set: Comment addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 int max_send_bitrate_bps_ = 0; 255 int max_send_bitrate_bps_ = 0;
256 AudioOptions options_; 256 AudioOptions options_;
257 rtc::Optional<int> dtmf_payload_type_; 257 rtc::Optional<int> dtmf_payload_type_;
258 int dtmf_payload_freq_ = -1; 258 int dtmf_payload_freq_ = -1;
259 bool recv_transport_cc_enabled_ = false; 259 bool recv_transport_cc_enabled_ = false;
260 bool recv_nack_enabled_ = false; 260 bool recv_nack_enabled_ = false;
261 bool desired_playout_ = false; 261 bool desired_playout_ = false;
262 bool playout_ = false; 262 bool playout_ = false;
263 bool send_ = false; 263 bool send_ = false;
264 webrtc::Call* const call_ = nullptr; 264 webrtc::Call* const call_ = nullptr;
265 webrtc::Call::Config::BitrateConfig bitrate_config_;
266 265
267 // Queue of unsignaled SSRCs; oldest at the beginning. 266 // Queue of unsignaled SSRCs; oldest at the beginning.
268 std::vector<uint32_t> unsignaled_recv_ssrcs_; 267 std::vector<uint32_t> unsignaled_recv_ssrcs_;
269 268
270 // Volume for unsignaled streams, which may be set before the stream exists. 269 // Volume for unsignaled streams, which may be set before the stream exists.
271 double default_recv_volume_ = 1.0; 270 double default_recv_volume_ = 1.0;
272 // Sink for latest unsignaled stream - may be set before the stream exists. 271 // Sink for latest unsignaled stream - may be set before the stream exists.
273 std::unique_ptr<webrtc::AudioSinkInterface> default_sink_; 272 std::unique_ptr<webrtc::AudioSinkInterface> default_sink_;
274 // Default SSRC to use for RTCP receiver reports in case of no signaled 273 // Default SSRC to use for RTCP receiver reports in case of no signaled
275 // send streams. See: https://code.google.com/p/webrtc/issues/detail?id=4740 274 // send streams. See: https://code.google.com/p/webrtc/issues/detail?id=4740
276 // and https://code.google.com/p/chromium/issues/detail?id=547661 275 // and https://code.google.com/p/chromium/issues/detail?id=547661
277 uint32_t receiver_reports_ssrc_ = 0xFA17FA17u; 276 uint32_t receiver_reports_ssrc_ = 0xFA17FA17u;
278 277
279 class WebRtcAudioSendStream; 278 class WebRtcAudioSendStream;
280 std::map<uint32_t, WebRtcAudioSendStream*> send_streams_; 279 std::map<uint32_t, WebRtcAudioSendStream*> send_streams_;
281 std::vector<webrtc::RtpExtension> send_rtp_extensions_; 280 std::vector<webrtc::RtpExtension> send_rtp_extensions_;
282 281
283 class WebRtcAudioReceiveStream; 282 class WebRtcAudioReceiveStream;
284 std::map<uint32_t, WebRtcAudioReceiveStream*> recv_streams_; 283 std::map<uint32_t, WebRtcAudioReceiveStream*> recv_streams_;
285 std::vector<webrtc::RtpExtension> recv_rtp_extensions_; 284 std::vector<webrtc::RtpExtension> recv_rtp_extensions_;
286 285
287 webrtc::AudioSendStream::Config::SendCodecSpec send_codec_spec_; 286 webrtc::AudioSendStream::Config::SendCodecSpec send_codec_spec_;
288 287
289 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcVoiceMediaChannel); 288 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcVoiceMediaChannel);
290 }; 289 };
291 } // namespace cricket 290 } // namespace cricket
292 291
293 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVOICEENGINE_H_ 292 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVOICEENGINE_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698