Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 2779853002: [DevTools] Allow hide timeout in popover be longer than show timeout (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Allow hide timeout in popover be longer than show timeout This is useful for timeline overview. To support long hide timeout we should hide immediately before showing new popover and cancel the timeout. If we don't show the new popover, old one will be hidden after a long timeout, which makes it easier to reach popover with mouse. BUG=704424 Review-Url: https://codereview.chromium.org/2779853002 Cr-Commit-Position: refs/heads/master@{#459978} Committed: https://chromium.googlesource.com/chromium/src/+/9d8f7b92656f41598fe2ce4e7cc1979fc339ebc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dgozman
Could you please take a look?
3 years, 8 months ago (2017-03-27 23:07:00 UTC) #2
lushnikov
lgtm
3 years, 8 months ago (2017-03-27 23:57:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779853002/1
3 years, 8 months ago (2017-03-28 00:11:54 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 01:54:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d8f7b92656f41598fe2ce4e7cc1...

Powered by Google App Engine
This is Rietveld 408576698