Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

Issue 2779853002: [DevTools] Allow hide timeout in popover be longer than show timeout (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
index 4d6ec06c20cc61e03b96bb6f3c4201e7bdb2def5..925b4a72127177137207c40c5f801ea400cd2a6d 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
@@ -111,8 +111,7 @@ UI.PopoverHelper = class {
this._stopShowPopoverTimer();
if (event.which && this._disableOnClick)
return;
- this._startShowPopoverTimer(
- event, this.isPopoverVisible() ? Math.max(this._timeout * 0.6, this._hideTimeout) : this._timeout);
+ this._startShowPopoverTimer(event, this.isPopoverVisible() ? this._timeout * 0.6 : this._timeout);
}
/**
@@ -168,6 +167,8 @@ UI.PopoverHelper = class {
this._showPopoverTimer = setTimeout(() => {
delete this._showPopoverTimer;
+ this._stopHidePopoverTimer();
+ this._hidePopover();
this._showPopover(event.target.ownerDocument);
}, timeout);
}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698