Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2774833003: Reland "WebRtcVoiceMediaChannel::AddRecvStream: Don't call SetRecPayloadType" (Closed)

Created:
3 years, 9 months ago by kwiberg-webrtc
Modified:
3 years, 8 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, danilchap, AleBzk, peah-webrtc, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, mflodman, kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "WebRtcVoiceMediaChannel::AddRecvStream: Don't call SetRecPayloadType" BUG=webrtc:5805 Review-Url: https://codereview.webrtc.org/2774833003 Cr-Commit-Position: refs/heads/master@{#17391} Committed: https://chromium.googlesource.com/external/webrtc/+/1c07c70d88eca07888bf242921dc8dfc3be95737

Patch Set 1 : Original CL #

Patch Set 2 : Actually set up a decoder---we don't get it by default anymore #

Patch Set 3 : Don't stop setting up a default set of send codecs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -170 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/call/call_perf_tests.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/call/call_unittest.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 5 chunks +10 lines, -40 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 7 chunks +34 lines, -77 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 4 chunks +8 lines, -23 lines 0 comments Download
M webrtc/modules/audio_coding/include/audio_coding_module.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/test/mock_voice_engine.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 4 chunks +52 lines, -24 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/conference_transport.cc View 1 2 5 chunks +14 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/codec_before_streaming_test.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kwiberg-webrtc
3 years, 9 months ago (2017-03-27 12:50:11 UTC) #4
the sun
lgtm
3 years, 9 months ago (2017-03-27 14:09:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2774833003/40001
3 years, 9 months ago (2017-03-27 14:13:15 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/1c07c70d88eca07888bf242921dc8dfc3be95737
3 years, 9 months ago (2017-03-27 14:15:55 UTC) #12
oprypin_webrtc
3 years, 8 months ago (2017-03-28 18:32:34 UTC) #14
Message was sent while issue was closed.
The reland still causes the breakage of the test on the perfbot - see
https://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/build...

The test in question:
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/audio/test/...

This is reproducible locally. Seems like it's getting no audio on the receive
side. The error you can see on the perfbot is just a complaint that the audio
file is empty (which is indeed shorter than 1/4 sec).

I guess this indicates that this type of failure could be handled better in the
test (maybe even on trybots). But we still need to get to the bottom of the
problem and fix the test.

Powered by Google App Engine
This is Rietveld 408576698