webrtc/media/engine/webrtcvoiceengine.h - Issue 2774833003: Reland "WebRtcVoiceMediaChannel::AddRecvStream: Don't call SetRecPayloadType"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 2774833003: Reland "WebRtcVoiceMediaChannel::AddRecvStream: Don't call SetRecPayloadType" (Closed)

Patch Set: Don't stop setting up a default set of send codecs Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvoiceengine.h

diff --git a/webrtc/media/engine/webrtcvoiceengine.h b/webrtc/media/engine/webrtcvoiceengine.h

index c777c6c03e45a0cafd0c39319d404ab9f27e27c9..64f7afabf61dc2b51e9624f5bd545afb70299c10 100644

--- a/webrtc/media/engine/webrtcvoiceengine.h

+++ b/webrtc/media/engine/webrtcvoiceengine.h

@@ -251,7 +251,12 @@ class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,

WebRtcVoiceEngine* const engine_ = nullptr;

std::vector<AudioCodec> send_codecs_;

+ // TODO(kwiberg): decoder_map_ and recv_codecs_ store the exact same

+ // information, in slightly different formats. Eliminate recv_codecs_.

+ std::map<int, webrtc::SdpAudioFormat> decoder_map_;

std::vector<AudioCodec> recv_codecs_;

int max_send_bitrate_bps_ = 0;

AudioOptions options_;

rtc::Optional<int> dtmf_payload_type_;