Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2770883004: PRESUBMIT: Improve error message about checkdeps. (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

PRESUBMIT: Improve error message about checkdeps. This will make it easier for new project members to know what's causing the error. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2770883004 Cr-Commit-Position: refs/heads/master@{#17358} Committed: https://chromium.googlesource.com/external/webrtc/+/a7066a35ba9317d9ce04f52b8242eb80aa28dc5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
3 years, 9 months ago (2017-03-23 10:34:40 UTC) #2
mbonadei
On 2017/03/23 10:34:40, kjellander_webrtc wrote: lgtm.
3 years, 9 months ago (2017-03-23 10:41:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2770883004/1
3 years, 9 months ago (2017-03-23 10:44:11 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 10:47:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a7066a35ba9317d9ce04f52b8...

Powered by Google App Engine
This is Rietveld 408576698