Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: PRESUBMIT.py

Issue 2770883004: PRESUBMIT: Improve error message about checkdeps. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 03a77b28681d9df9e72559a4d71c3418159661dc..24a8f74fd8031c8d280d55855c87562f637649dd 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -398,13 +398,18 @@ def _CheckUnwantedDependencies(input_api, output_api):
results = []
if error_descriptions:
results.append(output_api.PresubmitError(
- 'You added one or more #includes that violate checkdeps rules.',
+ 'You added one or more #includes that violate checkdeps rules.\n'
+ 'Check that the DEPS files in these locations contain valid rules.\n'
+ 'See https://cs.chromium.org/chromium/src/buildtools/checkdeps/ for '
+ 'more details about checkdeps.',
error_descriptions))
if warning_descriptions:
results.append(output_api.PresubmitPromptOrNotify(
'You added one or more #includes of files that are temporarily\n'
'allowed but being removed. Can you avoid introducing the\n'
- '#include? See relevant DEPS file(s) for details and contacts.',
+ '#include? See relevant DEPS file(s) for details and contacts.\n'
+ 'See https://cs.chromium.org/chromium/src/buildtools/checkdeps/ for '
+ 'more details about checkdeps.',
warning_descriptions))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698