Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2769863007: H264 Supplemental Enhancement Information no longer considered a keyframe. (Closed)

Created:
3 years, 9 months ago by philipel
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc, Stefan
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

H264 Supplemental Enhancement Information no longer considered a keyframe. BUG=none Review-Url: https://codereview.webrtc.org/2769863007 Cr-Commit-Position: refs/heads/master@{#17435} Committed: https://chromium.googlesource.com/external/webrtc/+/0f0a849cba51ae68e508c04f4abac9e36fbbeb05

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Update test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
philipel
3 years, 9 months ago (2017-03-24 16:12:57 UTC) #2
Stefan
Update tests. Add BUG= if you want this merged somewhere.
3 years, 8 months ago (2017-03-28 14:53:47 UTC) #12
Stefan
lgtm
3 years, 8 months ago (2017-03-28 14:54:09 UTC) #13
stefan-webrtc
lgtm
3 years, 8 months ago (2017-03-28 14:54:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2769863007/40001
3 years, 8 months ago (2017-03-29 08:42:35 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 09:20:03 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/0f0a849cba51ae68e508c04f4...

Powered by Google App Engine
This is Rietveld 408576698