Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc

Issue 2769863007: H264 Supplemental Enhancement Information no longer considered a keyframe. (Closed)
Patch Set: Update test. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 533 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 LOG(LS_WARNING) << "Failed to parse PPS id from slice of type: " 544 LOG(LS_WARNING) << "Failed to parse PPS id from slice of type: "
545 << static_cast<int>(nalu.type); 545 << static_cast<int>(nalu.type);
546 } 546 }
547 break; 547 break;
548 } 548 }
549 // Slices below don't contain SPS or PPS ids. 549 // Slices below don't contain SPS or PPS ids.
550 case H264::NaluType::kAud: 550 case H264::NaluType::kAud:
551 case H264::NaluType::kEndOfSequence: 551 case H264::NaluType::kEndOfSequence:
552 case H264::NaluType::kEndOfStream: 552 case H264::NaluType::kEndOfStream:
553 case H264::NaluType::kFiller: 553 case H264::NaluType::kFiller:
554 break;
555 case H264::NaluType::kSei: 554 case H264::NaluType::kSei:
556 parsed_payload->frame_type = kVideoFrameKey;
557 break; 555 break;
558 case H264::NaluType::kStapA: 556 case H264::NaluType::kStapA:
559 case H264::NaluType::kFuA: 557 case H264::NaluType::kFuA:
560 LOG(LS_WARNING) << "Unexpected STAP-A or FU-A received."; 558 LOG(LS_WARNING) << "Unexpected STAP-A or FU-A received.";
561 return false; 559 return false;
562 } 560 }
563 RTPVideoHeaderH264* h264 = &parsed_payload->type.Video.codecHeader.H264; 561 RTPVideoHeaderH264* h264 = &parsed_payload->type.Video.codecHeader.H264;
564 if (h264->nalus_length == kMaxNalusPerPacket) { 562 if (h264->nalus_length == kMaxNalusPerPacket) {
565 LOG(LS_WARNING) 563 LOG(LS_WARNING)
566 << "Received packet containing more than " << kMaxNalusPerPacket 564 << "Received packet containing more than " << kMaxNalusPerPacket
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 h264->packetization_type = kH264FuA; 619 h264->packetization_type = kH264FuA;
622 h264->nalu_type = original_nal_type; 620 h264->nalu_type = original_nal_type;
623 if (first_fragment) { 621 if (first_fragment) {
624 h264->nalus[h264->nalus_length] = nalu; 622 h264->nalus[h264->nalus_length] = nalu;
625 h264->nalus_length = 1; 623 h264->nalus_length = 1;
626 } 624 }
627 return true; 625 return true;
628 } 626 }
629 627
630 } // namespace webrtc 628 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698