Issue 2767773002: DxgiOutputDuplicator should initialize num_frames_captured_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2767773002: DxgiOutputDuplicator should initialize num_frames_captured_ (Closed)

Created:
3 years, 9 months ago by Sergey Ulanov

Modified:
3 years, 9 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org

Target Ref:
refs/branch-heads/58

Project:
webrtc

Visibility:
Public.

DxgiOutputDuplicator should initialize num_frames_captured_ Otherwise Check failed: !!last_frame_ == num_frames_captured_ > 0 (1 vs. 0) may be triggered. BUG=webrtc:7339, chromium:702044 Review-Url: https://codereview.webrtc.org/2755493003 Cr-Commit-Position: refs/heads/master@{#17266} (cherry picked from commit 299b67809adb928d446440367ec16da865f64166) Review-Url: https://codereview.webrtc.org/2767773002 . Cr-Commit-Position: refs/branch-heads/58@{#6} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} Committed: https://chromium.googlesource.com/external/webrtc/+/d339f300ce5e5848c66c41de6206dd8f0a448aa3

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Sergey Ulanov

3 years, 9 months ago (2017-03-21 21:54:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d339f300ce5e5848c66c41de6206dd8f0a448aa3.