Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2755493003: DxgiOutputDuplicator should initialize num_frames_captured_ (Closed)

Created:
3 years, 9 months ago by Hzj_jie
Modified:
3 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Jamie
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

DxgiOutputDuplicator should initialize num_frames_captured_ Otherwise Check failed: !!last_frame_ == num_frames_captured_ > 0 (1 vs. 0) may be triggered. BUG=webrtc:7339 Review-Url: https://codereview.webrtc.org/2755493003 Cr-Commit-Position: refs/heads/master@{#17266} Committed: https://chromium.googlesource.com/external/webrtc/+/299b67809adb928d446440367ec16da865f64166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Hzj_jie
3 years, 9 months ago (2017-03-15 02:22:21 UTC) #5
Sergey Ulanov
LGTM. Does this need to be merged to M58?
3 years, 9 months ago (2017-03-15 22:04:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2755493003/1
3 years, 9 months ago (2017-03-15 22:49:27 UTC) #10
Hzj_jie
On 2017/03/15 22:04:21, Sergey Ulanov wrote: > LGTM. Does this need to be merged to ...
3 years, 9 months ago (2017-03-15 22:52:16 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 22:52:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/299b67809adb928d446440367...

Powered by Google App Engine
This is Rietveld 408576698