Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2765243002: Delete RawVideoType enum, use the VideoType enum instead. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 7 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, the sun, perkj_webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete RawVideoType enum, use the VideoType enum instead. BUG=webrtc:7385 Review-Url: https://codereview.webrtc.org/2765243002 Cr-Commit-Position: refs/heads/master@{#17930} Committed: https://chromium.googlesource.com/external/webrtc/+/eb44b39a216f2e7bfb2a805f19becd6bf28ec261

Patch Set 1 #

Patch Set 2 : Fix compile problem on ios. #

Patch Set 3 : Fix compile problem on windows. #

Patch Set 4 : Rebase. #

Patch Set 5 : Define constant webrtc::kI420, for backwards compatibility. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -309 lines) Patch
M webrtc/common_types.h View 1 2 3 1 chunk +19 lines, -17 lines 0 comments Download
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 1 2 3 4 1 chunk +4 lines, -24 lines 0 comments Download
M webrtc/common_video/libyuv/libyuv_unittest.cc View 9 chunks +43 lines, -39 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 3 chunks +30 lines, -66 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 3 chunks +37 lines, -34 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/device_info_impl.cc View 1 2 3 6 chunks +14 lines, -14 lines 0 comments Download
M webrtc/modules/video_capture/linux/device_info_linux.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/video_capture/linux/video_capture_linux.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/linux/video_capture_linux.cc View 1 2 3 6 chunks +13 lines, -16 lines 0 comments Download
M webrtc/modules/video_capture/objc/device_info_objc.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_capture/objc/rtc_video_capture_objc.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/objc/video_capture.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 1 2 3 6 chunks +8 lines, -10 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_defines.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 1 2 3 3 chunks +5 lines, -8 lines 0 comments Download
M webrtc/modules/video_capture/windows/device_info_ds.cc View 2 chunks +13 lines, -11 lines 0 comments Download
M webrtc/modules/video_capture/windows/sink_filter_ds.cc View 2 chunks +25 lines, -25 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/i420/i420.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/test/frame_generator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/gl/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/vcm_capturer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/win/d3d_renderer.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/tools/frame_editing/frame_editing_lib.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/frame_editing/frame_editing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
nisse-webrtc
PTAL. I wonder if we should aim to delete VideoType too, and use fourcc everywhere. ...
3 years, 9 months ago (2017-03-23 14:03:04 UTC) #2
mflodman
lgtm
3 years, 7 months ago (2017-04-27 14:47:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2765243002/80001
3 years, 7 months ago (2017-04-28 13:42:28 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 14:18:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/eb44b39a216f2e7bfb2a805f1...

Powered by Google App Engine
This is Rietveld 408576698