Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2764523002: Enable complete_static_lib on Mac and iOS (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable complete_static_lib on Mac and iOS BUG=webrtc:6418 NOTRY=True Review-Url: https://codereview.webrtc.org/2764523002 Cr-Commit-Position: refs/heads/master@{#17354} Committed: https://chromium.googlesource.com/external/webrtc/+/7007bcf5b3372c76c4cf5630a54acf089a32eeaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -34 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -11 lines 0 comments Download
D webrtc/no_op_function.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kjellander_webrtc
Turned out this has been possible for a long time. The warnings produced don't have ...
3 years, 9 months ago (2017-03-22 18:32:31 UTC) #3
henrika_webrtc
LGTM % the fact that I am no expert in the details.
3 years, 9 months ago (2017-03-23 09:11:16 UTC) #5
kthelgason
rs-lgtm
3 years, 9 months ago (2017-03-23 09:29:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2764523002/1
3 years, 9 months ago (2017-03-23 09:47:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/7007bcf5b3372c76c4cf5630a54acf089a32eeaa
3 years, 9 months ago (2017-03-23 09:49:19 UTC) #11
kthelgason
On 2017/03/23 09:49:19, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-03-23 14:20:09 UTC) #12
kjellander_webrtc
3 years, 9 months ago (2017-03-23 15:01:41 UTC) #13
Message was sent while issue was closed.
On 2017/03/23 14:20:09, kthelgason wrote:
> On 2017/03/23 09:49:19, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/external/webrtc/+/7007bcf5b3372c76c4cf5630a...
> 
> Not super-thrilled about seeing this error in my build all the time though. Is
> there anything that can be done about that?

Hmm, I don't know from the top of my head. File a GN bug and try to get it fixed
/ behavior changed?

Powered by Google App Engine
This is Rietveld 408576698