Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: webrtc/BUILD.gn

Issue 2764523002: Enable complete_static_lib on Mac and iOS (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/no_op_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index f979ff1147d1934f78cd233452e47b212a5e9cea..c928dd396d7dade5167b1ae8a0c451966d7be68d 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -231,17 +231,7 @@ if (!build_with_chromium) {
"call.h",
"config.h",
]
-
- # complete_static_lib doesn't work on Mac since libtool cannot support
- # multiple objects with the same filenames (https://bugs.webrtc.org/6418).
- if (is_win || is_linux || is_android) {
- complete_static_lib = true
- } else {
- # TODO(kjellander): Remove this whenever possible. GN's static_library
- # target type requires at least one object to avoid errors linking.
- sources += [ "no_op_function.cc" ]
- }
-
+ complete_static_lib = true
defines = []
deps = [
« no previous file with comments | « no previous file | webrtc/no_op_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698