third_party/WebKit/Source/core/frame/RemoteFrame.h - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrame.h

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/RemoteFrame.h

diff --git a/third_party/WebKit/Source/core/frame/RemoteFrame.h b/third_party/WebKit/Source/core/frame/RemoteFrame.h

index f2fdbf8263ee678e6ae3606d691a2862d8a16cc4..16c4d203784094289ac27d5544c86383557d053d 100644

--- a/third_party/WebKit/Source/core/frame/RemoteFrame.h

+++ b/third_party/WebKit/Source/core/frame/RemoteFrame.h

@@ -21,7 +21,7 @@ struct FrameLoadRequest;

class CORE_EXPORT RemoteFrame final : public Frame {

public:

- static RemoteFrame* create(RemoteFrameClient*, Page*, FrameOwner*);

+ static RemoteFrame* create(RemoteFrameClient*, Page&, FrameOwner*);

~RemoteFrame() override;

@@ -57,7 +57,7 @@ class CORE_EXPORT RemoteFrame final : public Frame {

RemoteFrameClient* client() const;

private:

- RemoteFrame(RemoteFrameClient*, Page*, FrameOwner*);

+ RemoteFrame(RemoteFrameClient*, Page&, FrameOwner*);

// Intentionally private to prevent redundant checks when the type is

// already RemoteFrame.