third_party/WebKit/Source/core/frame/RemoteFrame.cpp - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp

index e864435226d862991a9816cad4617f57d8fc1615..866bca73ffdc589e3ff5721388e970ef14748535 100644

--- a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp

@@ -27,7 +27,7 @@

namespace blink {

inline RemoteFrame::RemoteFrame(RemoteFrameClient* client,

- Page* page,

+ Page& page,

FrameOwner* owner)

: Frame(client, page, owner, RemoteWindowProxyManager::create(*this)),

m_securityContext(RemoteSecurityContext::create()) {

@@ -35,7 +35,7 @@ inline RemoteFrame::RemoteFrame(RemoteFrameClient* client,

}

RemoteFrame* RemoteFrame::create(RemoteFrameClient* client,

- Page* page,

+ Page& page,

FrameOwner* owner) {

return new RemoteFrame(client, page, owner);

}