third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

index 29858793e2824b80e965916f31b1da521dcc80e7..39337e8cf2c6d3faab8c881a2047e8dcfc2d1161 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

@@ -24,7 +24,7 @@ LocalFrame* SingleChildLocalFrameClient::createFrame(

LocalFrame* parentFrame = ownerElement->document().frame();

auto* childClient = LocalFrameClientWithParent::create(parentFrame);

- m_child = LocalFrame::create(childClient, parentFrame->page(), ownerElement);

+ m_child = LocalFrame::create(childClient, *parentFrame->page(), ownerElement);

m_child->createView(IntSize(500, 500), Color(), true /* transparent */);

m_child->init();